Skip to content

map: Add Points of Interest (PoI) feature to the maps#1906

Merged
rafaellehmkuhl merged 2 commits into
bluerobotics:masterfrom
rafaellehmkuhl:allow-points-of-interest-map
May 30, 2025
Merged

map: Add Points of Interest (PoI) feature to the maps#1906
rafaellehmkuhl merged 2 commits into
bluerobotics:masterfrom
rafaellehmkuhl:allow-points-of-interest-map

Conversation

@rafaellehmkuhl

@rafaellehmkuhl rafaellehmkuhl commented May 22, 2025

Copy link
Copy Markdown
Member

This feature allows the user to add markers to their map, so they can annotate places where they need to go, to avoid, or something else.

Each PoI has its own icon, color, name, description and position.

All PoIs are persistent, synced between the map and the mission-planning view, and also synced with the vehicle.

Kapture.2025-05-22.at.13.19.59.mp4

@rafaellehmkuhl
rafaellehmkuhl force-pushed the allow-points-of-interest-map branch from 9851e2e to 25c02a8 Compare May 22, 2025 16:29
@rafaellehmkuhl rafaellehmkuhl changed the title map: Add Points of Interest (PoI) feature map: Add Points of Interest (PoI) feature to the maps May 22, 2025

@ArturoManzoli ArturoManzoli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good feature

Some UI suggestions:
(1) The step adjustment on the input could be on a meter scale (around 0.00001 on the GPS). As it is now, a 1.0 step represents something around 100 km displacement;
(2) The Building icon doesn't show up for me;
(3) Add the usual divider between the content and the footer;
(4) On the context menu says Place point of interest and on the modal title says Add point of interest. I think we should pick one, and 'place' is best.

image

@ArturoManzoli

ArturoManzoli commented May 22, 2025

Copy link
Copy Markdown
Contributor

Also the coordinates editing for the Poi should be reactive. Would be nice to change its place step by step watching it moving on the map. So users can get a more precise relocation

  • To keep UI consistency the delete button should be white;
Screenshare.-.2025-05-22.3_54_30.PM.mp4

@ArturoManzoli

Copy link
Copy Markdown
Contributor

The color picker's theme should be on theme="dark"

image

Comment thread src/views/MissionPlanningView.vue Outdated
Comment thread src/views/MissionPlanningView.vue Outdated
@ES-Alexander

Copy link
Copy Markdown
Contributor

@ES-Alexander ES-Alexander left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Creating a point leaves behind an extra blue dot with the same hover behaviour as the PoI, until some other point is created, or escape is pressed:
    Screenshot 2025-05-24 at 12 21 31 am
  2. Zooming the map brings some points with you, instead of staying at the GPS locations
    • Panning works as expected
    • Tooltips are generally at the right location, although they don't update (live) if zooming while hovering on a point
      Screenshot 2025-05-24 at 12 28 30 am
    • Deleting or creating a new point seems to re-render the existing ones in the correct locations
  3. It could be nice to start with a random colour, so they're not all red by default, and maybe allow choosing the colour from a palette, so it's not painful to get the same colour for points of a similar type

@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label May 23, 2025
@rafaellehmkuhl
rafaellehmkuhl force-pushed the allow-points-of-interest-map branch 2 times, most recently from e12a341 to 35463e3 Compare May 27, 2025 19:06
@rafaellehmkuhl

Copy link
Copy Markdown
Member Author

@ArturoManzoli @ES-Alexander I think I was able to get everything fixed, including the zoom problem. Thanks for letting me know.

@rafaellehmkuhl
rafaellehmkuhl force-pushed the allow-points-of-interest-map branch from 35463e3 to d3659a1 Compare May 27, 2025 19:08
@ArturoManzoli

ArturoManzoli commented May 27, 2025

Copy link
Copy Markdown
Contributor

Nice,
Looking good now

Just one more thing:
The delete text button should be white to ensure visibility in most situations and to align with our design language.

image

This feature allows the user to add markers to their map, so they can annotate places where they need to go, to avoid, or something else.

Each PoI has its own icon, color, name, description and position.

All PoIs are synced with the vehicle.
@rafaellehmkuhl
rafaellehmkuhl force-pushed the allow-points-of-interest-map branch from d3659a1 to be1cbc0 Compare May 28, 2025 13:00
@rafaellehmkuhl

Copy link
Copy Markdown
Member Author

Nice, Looking good now

Just one more thing: The delete text button should be white to ensure visibility in most situations and to align with our design language.

Done.

@rafaellehmkuhl

Copy link
Copy Markdown
Member Author

Thanks @ArturoManzoli.
@ES-Alexander I will wait for your approval before merging.

@rafaellehmkuhl
rafaellehmkuhl merged commit 2f0e7ed into bluerobotics:master May 30, 2025
@rafaellehmkuhl
rafaellehmkuhl deleted the allow-points-of-interest-map branch May 30, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-needed Change needs to be documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants