Skip to content

Improve and fix MAVLink system/component handling#2229

Merged
ES-Alexander merged 2 commits into
bluerobotics:masterfrom
ES-Alexander:improve-mavlink-id-handling
Nov 17, 2025
Merged

Improve and fix MAVLink system/component handling#2229
ES-Alexander merged 2 commits into
bluerobotics:masterfrom
ES-Alexander:improve-mavlink-id-handling

Conversation

@ES-Alexander

@ES-Alexander ES-Alexander commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

Building on #1815:

  1. Removes redundant MAVLink ID field names from the Data Lake variable IDs
    • e.g. /mavlink/system=1/component=1/HEARTBEAT/base_mode --> /mavlink/1/1/HEARTBEAT/base_mode
    • The system and component designations are already spelled out in the (human-readable) variable name, so don't need to also be included in the (machine-differentiable) variable IDs
    • This also makes them better match the MAVLink paths used in Zenoh in the latest BlueOS betas, which could make for more straightforward integration later (as pointed out by @joaoantoniocardoso)
  2. Fixes the legacy variable creation to only apply to the main system's autopilot component
    • Other systems and components were not supported in this style previously, and
    • Including them without the system and component prefix for disambiguation means the values would overwrite from any connected systems and components (which, from past experience, is quite confusing).

The system and component designations are already spelled out in the (human-readable) variable name, so don't need to also be included in the (machine-differentiable) variable IDs.

This also makes them better match the MAVLink paths used in Zenoh in the latest BlueOS betas, which could make for more straightforward integration later.
Other systems and components were not supported in this style previously, and doing so without the system and component prefix for disambiguation means the values would overwrite from any connected systems and components (which, from past experience, is quite confusing).
@ES-Alexander
ES-Alexander force-pushed the improve-mavlink-id-handling branch from 2dd929e to 88bd94b Compare November 14, 2025 00:37
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Nov 14, 2025

@rafaellehmkuhl rafaellehmkuhl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@ES-Alexander
ES-Alexander merged commit bfaef9c into bluerobotics:master Nov 17, 2025
12 checks passed
@ES-Alexander
ES-Alexander deleted the improve-mavlink-id-handling branch November 17, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-needed Change needs to be documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants