Mission-planning: Enhance mission creation and editing workflow#2541
Conversation
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
…changes Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com> Made-with: Cursor
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com> Made-with: Cursor
e27269f to
1434d91
Compare
ES-Alexander
left a comment
There was a problem hiding this comment.
Only had time for a brief test, and a skim through the code.
From that testing, things seem to be generally functioning as expected - nice! :-)
Some minor issues:
- If the survey menu is left / up from the survey then it's appearing quite far away


- In the top left corner, the survey menu can still end up partly out of the screen

- Possibly out of scope, but the right click context menu for the map can also go off the screen at the bottom

- The tiny arrows for showing the redo and mission load buttons seem hard to use / understand
- I think it makes more sense to move the hide/show mission estimates config into the mission settings, and add an icon to hide mission estimates on the actual mission estimates widget, and then use the extra space to just have the
undo/redo | save/load | delete | settingsmenu options in full
- I think it makes more sense to move the hide/show mission estimates config into the mission settings, and add an icon to hide mission estimates on the actual mission estimates widget, and then use the extra space to just have the
| if (isCreatingSurvey.value) return | ||
|
|
||
| const snapshot = missionStore.popRedoSnapshot() | ||
| if (!snapshot) return |
There was a problem hiding this comment.
Should there be some kind of warning here for the user, that the redo stack is empty?
There was a problem hiding this comment.
Added the warning, even though this return was a second layer of protection. I don't think this will be triggered on a normal situation
| </template> | ||
| </v-tooltip> | ||
| <div v-if="missionStore.currentPlanningWaypoints.length > 0" class="speed-dial-group"> | ||
| <v-tooltip location="top" text="Undo (Ctrl+Z)"> |
There was a problem hiding this comment.
Would be good if this could say Cmd+Z for Mac, or use the command symbol (⌘). Same for the redo case.
1434d91 to
c93cbe2
Compare
Fixed. Now its under the pointer's edge unless too close to the edges, where it opens a little closer to the screen's center.
Fixed
It was actually on the scope. Fixed too
Indeed, that wasn't the best layout. Moved the mission estimates hide button to its container and added a switch to the mission options menu. |
ES-Alexander
left a comment
There was a problem hiding this comment.
Noting that I haven't looked through the code super closely - I've mostly just tested functionality.
Approving because I don't expect these remaining fixes need re-testing.
-
With a turnaround distance specified, it's possible to undo into a state where just the turnaround lines are shown, during survey creation:

- This would ideally be cleared as part of the undo process, but it still clears fine when enough polygon points are drawn to generate new lines, or if the survey gets cancelled, so it's not a huge deal either way (just feels a bit janky).
-
When you swap the start and end points, then edit the survey polygon, then generate waypoints, the swapping is forgotten
- It seems intuitive that it would be maintained, but it's one extra button click after a potentially quite major change to the survey, so again just a small polish point.
|
|
||
| const performUndo = (): void => { | ||
| const snapshot = missionStore.popUndoSnapshot() | ||
| if (!snapshot) return |
There was a problem hiding this comment.
We should also have a warning about this, like the redo one.
|
|
||
| const snapshot = missionStore.popRedoSnapshot() | ||
| if (!snapshot) { | ||
| openSnackbar({ variant: 'error', message: 'No more steps to redo.', duration: 2000 }) |
There was a problem hiding this comment.
Is there a way to suppress this if the warning is already being shown? If I hold down Cmd+Y until the stack is empty then I get a big spam of warnings - one would be enough.
There was a problem hiding this comment.
Added the message also to the undo command, and on both, added a trigger to display the message only once per cycle
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
c93cbe2 to
6a3cabd
Compare
Fixed!
Fixed! |
Survey editing
Survey operations
Undo system
UI polish
RadialMenucomponent for radial/pie-style context menusRelevant to #2516
Close #2445
Close #2446
Close #1349
Close #2052