Skip to content

ui: joystick: Fix vertical spacing in the input mapping dialog#2564

Merged
rafaellehmkuhl merged 1 commit into
bluerobotics:masterfrom
rafaellehmkuhl:fix-spacing-joystick-button-assingnment-dialog
Apr 10, 2026
Merged

ui: joystick: Fix vertical spacing in the input mapping dialog#2564
rafaellehmkuhl merged 1 commit into
bluerobotics:masterfrom
rafaellehmkuhl:fix-spacing-joystick-button-assingnment-dialog

Conversation

@rafaellehmkuhl

Copy link
Copy Markdown
Member

Before:

image

After:

image

@rafaellehmkuhl
rafaellehmkuhl force-pushed the fix-spacing-joystick-button-assingnment-dialog branch from 701c7d5 to 37a1918 Compare April 8, 2026 22:09
@rafaellehmkuhl

Copy link
Copy Markdown
Member Author

@ES-Alexander can you approve this one?

@ES-Alexander ES-Alexander left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why that went weird (it didn't look like that to start with), but the PR does seem to fix the issue, so approved 🤷‍♂️

That said, I think the whole column of stuff there would likely look better in the middle of the column of space:

Image

And we may wish to unwrap the "MAVLink Manual Control" label into a single line.

@rafaellehmkuhl

Copy link
Copy Markdown
Member Author

Not sure why that went weird (it didn't look like that to start with), but the PR does seem to fix the issue, so approved 🤷‍♂️

That said, I think the whole column of stuff there would likely look better in the middle of the column of space:

Agree. We could use some extra width for the entries indeed.

@rafaellehmkuhl
rafaellehmkuhl merged commit 41eba3e into bluerobotics:master Apr 10, 2026
11 checks passed
@rafaellehmkuhl
rafaellehmkuhl deleted the fix-spacing-joystick-button-assingnment-dialog branch April 10, 2026 17:34
@ES-Alexander

Copy link
Copy Markdown
Contributor

We could use some extra width for the entries indeed.

Hah! I was thinking of just horizontally centering the left column, but expanding the right column width (to reduce wrapping of the options) is likely a better idea - good suggestion.

@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-needed Change needs to be documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants