This repository was archived by the owner on Jan 26, 2022. It is now read-only.
Add http support to model downloading#9
Open
vikranth22446 wants to merge 2 commits into
Open
Conversation
nmalkin
suggested changes
Jun 10, 2021
nmalkin
reviewed
Jun 10, 2021
|
|
||
|
|
||
| def download_file(url, local_filename): | ||
| # local_filename = url.split('/')[-1] |
Contributor
There was a problem hiding this comment.
This can be deleted, I think.
| r.raise_for_status() | ||
| with open(local_filename, 'wb') as f: | ||
| for chunk in r.iter_content(chunk_size=8192): | ||
| # If you have chunk encoded response uncomment if |
Contributor
There was a problem hiding this comment.
What does "chunk encoded response" mean?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another small pr to add http model downloading support