Empty Tiled Writer#23
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 68.85% 69.94% +1.08%
==========================================
Files 14 14
Lines 1840 1853 +13
==========================================
+ Hits 1267 1296 +29
+ Misses 573 557 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielballan
left a comment
There was a problem hiding this comment.
Makes sense to me. I'd be interested in @tacaswell's two cents on whether this is the best way to do this.
Another option: I thought of doing it on the RunEngine side, as in:
# Subscribe (standard) TiledWriter but only feed it 'start' and 'stop' documents.
# To TiledWriter (and thus, to Tiled) it will appear as if each run is empty.
RE.subscribe(tw, 'start')
RE.subscribe(tw, 'stop')|
Ah yeah, that's even simpler! I forgot we can filter document types on subscription to RE. Might be tricky to remove unnecessary metadata from Start (if we want to be pedantic about not saving post-data-security data altogether in one place), but then we could also apply the access tags, which should work as usual. |
JunAishima
left a comment
There was a problem hiding this comment.
The new class and tests look good. I would also welcome further input on whether this is the best way to proceed.
|
Decision: Hold on this to see if |
This adds an
EmptyTiledWritercallback that only creates a container for the Bluesky run, registers the Start and Stop documents, but does not write any data.