Skip to content

Commit c1f67cf

Browse files
author
root
committed
Simplify, and fix off-by-one.
1 parent 93943e6 commit c1f67cf

1 file changed

Lines changed: 14 additions & 19 deletions

File tree

databroker/mongo_normalized.py

Lines changed: 14 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,7 @@ def _try_descr(field_metadata):
116116
if unicode_columns is None:
117117
unicode_columns = {}
118118
dim_counter = itertools.count()
119-
base_vars = {}
120-
struct_vars = {}
119+
data_vars = {}
121120

122121
for key, field_metadata in descriptor["data_keys"].items():
123122
# if the EventDescriptor doesn't provide names for the
@@ -195,25 +194,22 @@ def _try_descr(field_metadata):
195194
macro=ArrayMacroStructure(shape=shape, chunks=chunks),
196195
micro=dtype,
197196
)
198-
variable = VariableStructure(
199-
macro=VariableMacroStructure(dims=dims, data=data, attrs=attrs),
200-
micro=None,
201-
)
202-
data_array = DataArrayStructure(
203-
macro=DataArrayMacroStructure(variable, coords={}, name=key), micro=None
204-
)
205-
base_vars[key] = data_array
206197
else:
207-
struct_vars[key] = StructuredArrayTabularStructure(
198+
data = StructuredArrayTabularStructure(
208199
macro=ArrayTabularMacroStructure(chunks=chunks, shape=shape),
209200
micro=dtype,
210201
)
202+
variable = VariableStructure(
203+
macro=VariableMacroStructure(dims=dims, data=data, attrs=attrs),
204+
micro=None,
205+
)
206+
data_array = DataArrayStructure(
207+
macro=DataArrayMacroStructure(variable, coords={}, name=key), micro=None
208+
)
209+
data_vars[key] = data_array
211210

212-
return (
213-
DatasetMacroStructure(
214-
data_vars=base_vars, coords={"time": time_data_array}, attrs={}
215-
),
216-
TreeInMemory(struct_vars),
211+
return DatasetMacroStructure(
212+
data_vars=data_vars, coords={"time": time_data_array}, attrs={}
217213
)
218214

219215

@@ -498,10 +494,9 @@ def macrostructure(self):
498494
if unicode_keys:
499495
unicode_columns.update(self._get_columns(unicode_keys, slices=None))
500496

501-
old_ret, structed_data = structure_from_descriptor(
502-
descriptor, self._sub_dict, self._cutoff_seq_num - 1, unicode_columns
497+
return structure_from_descriptor(
498+
descriptor, self._sub_dict, self._cutoff_seq_num, unicode_columns
503499
)
504-
return old_ret
505500

506501
def microstructure(self):
507502
return None

0 commit comments

Comments
 (0)