Accept Multiple Providers in TagBasedAccessPolicy -- ON HOLD#1352
Open
genematx wants to merge 1 commit into
Open
Accept Multiple Providers in TagBasedAccessPolicy -- ON HOLD#1352genematx wants to merge 1 commit into
genematx wants to merge 1 commit into
Conversation
Allow configuring multiple identity providers in TagBasedAccessPolicy by accepting either a single string or a list of strings for the provider parameter.
Contributor
|
I'm a bit concerned about this under the current implementation, as there is no protection against a case like this:
If This is why the access policy was locked to a single provider for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow configuring multiple identity providers in
TagBasedAccessPolicyby accepting either a single string or a list of strings for the provider parameter.Checklist
Add the ticket number which this PR closes to the comment section