Refactoring AwkwardAdapter#1362
Open
genematx wants to merge 8 commits into
Open
Conversation
cjboyle
reviewed
Apr 29, 2026
cjboyle
approved these changes
Apr 29, 2026
Contributor
cjboyle
left a comment
cjboyle
left a comment
There was a problem hiding this comment.
It seems I can approve this, so I will approve this.
Co-authored-by: Connor Boyle <connor@cjboyle.ca>
|
Great job! No new security vulnerabilities introduced in this pull requestCommunicate with Checkmarx by submitting a PR comment with @Checkmarx followed by one of the supported commands. Learn about the supported commands here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor refactoring of
AwkwardAdapterand associated storage mechanisms without changes to the functionality.AwkwardBufferAdapteris removed and its methods (mainly the initialization of storage) are absorbed intoAwkwardAdapter.DirectoryContaineris moved totiled.storage, so it can be more cleanly reused by other mimetypes that require container storage (e.g. derivatives of awkward, such as ragged).Related: #1104
Checklist
Add the ticket number which this PR closes to the comment section