Commit b65b730
fix: address PR #230 review feedback
Triaged comments from coderabbit, gemini-code-assist, codex, and the
ongoing snyk investigation. Three valid actionable items + one false
positive class to flag.
1. Snyk: [tool.poetry] block was incomplete — Poetry requires
name/version/description/authors as required fields. Without them,
snyk's poetry parser rejects the block as invalid and reports
"pyproject.toml error Failed to detect issues" before even getting
to dependencies. Add the required identity fields, mirroring values
from [project] above. poetry-core 2.x prefers [project] when both
are present, so this duplication doesn't affect builds. Verified:
`python -m build` produces wheel + sdist correctly.
2. coderabbit: attrs missing upper bound for consistency with other
deps. Added `<27.0.0`. attrs uses year-based major versioning, so
this caps at the next year boundary — same pattern as other caret
constraints. Mirrored in [tool.poetry.dependencies] shim.
3. gemini-code-assist (medium) + coderabbit (nitpick): Dockerfile
builder stage had redundant `apt-get upgrade -y` (already done in
base stage) and missing `--no-install-recommends`. Removed the
redundant upgrade and added the flag. Verified: `docker build` +
`docker run --version` both work.
4. gemini-code-assist (3x "hallucination" comments on attrs 26.1.0,
ruff 0.15.12, uv 0.11.13): false positives. All three are real,
current package versions (verified via PyPI / GitHub releases /
ghcr.io image registry). Gemini's training data appears to predate
these releases; will reply on the comments rather than change code.
5. codex requirements.txt comment was already addressed in commit
7aa59b5 by adding `--quiet` to the export command — now generates
clean output without the resolver status line.
293/293 tests pass. Docker image builds in ~4s. Wheel + sdist build.
Co-Authored-By: Claude <noreply@anthropic.com>1 parent 283154b commit b65b730
3 files changed
Lines changed: 17 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
51 | 55 | | |
52 | | - | |
53 | | - | |
| 56 | + | |
54 | 57 | | |
55 | 58 | | |
56 | 59 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
90 | 99 | | |
91 | 100 | | |
92 | 101 | | |
93 | 102 | | |
94 | 103 | | |
95 | 104 | | |
96 | 105 | | |
97 | | - | |
| 106 | + | |
98 | 107 | | |
99 | 108 | | |
100 | 109 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments