perf(gap): route parse_advertisement_data_tuple misses through bytes cache (Bluetooth-Devices#261)

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: J. Nick Koston <nick@home-assistant.io>

Author: 3 people

src/bluetooth_data_tools/gap.py

@@ -190,9 +190,13 @@ def _uncached_parse_advertisement_data(data: bytes) -> BLEGAPAdvertisement:
 def _uncached_parse_advertisement_tuple(
     data: tuple[bytes, ...],
 ) -> BLEGAPAdvertisementTupleType:
-    return _uncached_parse_advertisement_bytes(
-        b"".join(data) if len(data) > 1 else data[0]
-    )
+    # Route tuple-cache misses through the bytes-keyed cache so identical
+    # content arriving via a fresh tuple identity still skips the full parse.
+    # The outer lru_cache around parse_advertisement_data_tuple owns the
+    # hit-path (C-level hash on the tuple, no join).
+    if len(data) == 1:
+        return parse_advertisement_data_bytes(data[0])
+    return parse_advertisement_data_bytes(b"".join(data))
 
 
 def _uncached_parse_advertisement_bytes(

tests/test_gap.py

@@ -1158,3 +1158,21 @@ def test_parse_advertisement_data_single_element_tuple_unwraps_to_bytes_cache():
     from_tuple = parse_advertisement_data((payload,))
     from_list = parse_advertisement_data([payload])
     assert from_tuple.local_name == from_list.local_name == "RZSS"
+
+
+def test_parse_advertisement_data_tuple_miss_falls_through_bytes_cache():
+    """A tuple-cache miss must consult the bytes-keyed cache before paying for
+    a full parse, so identical content arriving via a fresh tuple identity
+    still benefits from a previous bytes-form call.
+    """
+    payload = b"\x02\x01\x06\x05\tRZSS"
+
+    # Prime the bytes cache only.
+    parse_advertisement_data_tuple.cache_clear()
+    expected = parse_advertisement_data_bytes(payload)
+
+    # Tuple cache is empty, so this call must miss the tuple cache and resolve
+    # via the bytes cache.
+    assert parse_advertisement_data_tuple((payload,)) == expected
+    # Multi-chunk path: same content, fresh tuple identity, still bytes-cached.
+    assert parse_advertisement_data_tuple((b"", payload)) == expected