test: add comprehensive unit tests for controllerUtils#3466
Open
muhammadrashid4587 wants to merge 1 commit intobluewave-labs:developfrom
Open
test: add comprehensive unit tests for controllerUtils#3466muhammadrashid4587 wants to merge 1 commit intobluewave-labs:developfrom
muhammadrashid4587 wants to merge 1 commit intobluewave-labs:developfrom
Conversation
Add test coverage for all pure utility functions in controllerUtils: requireString, optionalString, optionalNumber, optionalBoolean, parseSortOrder, requireTeamId, requireUserId, requireUserEmail, requireFirstName, and requireUserRoles. Tests cover valid inputs, boundary values, type coercion, and error conditions for each function.
muhammadrashid4587
requested review from
Br0wnHammer,
Owaiseimdad,
ajhollid and
karenvicent
as code owners
ajhollid
requested changes
Apr 7, 2026
Collaborator
ajhollid
left a comment
ajhollid
left a comment
There was a problem hiding this comment.
Decent set of tests for the most part. Some tightening up is needed and we're good to go here. Thanks!
| optionalString, | ||
| optionalNumber, | ||
| optionalBoolean, | ||
| parseMonitorTypeFilter, |
Collaborator
There was a problem hiding this comment.
This is imported but not tested
Comment on lines
+215
to
+218
| it("returns the roles when valid", () => { | ||
| const roles = ["admin" as any]; | ||
| expect(requireUserRoles(roles)).toEqual(roles); | ||
| }); |
Collaborator
There was a problem hiding this comment.
Casting to any defeats the purpose here. Essentially this says
const a = 1;
expect a = 1;
Yeah.. its true, but what's the point?
|
|
||
| it("throws for boolean", () => { | ||
| expect(() => optionalNumber(true, "count")).toThrow("count must be a number"); | ||
| }); |
Collaborator
There was a problem hiding this comment.
What about null? Let's add a test case for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
controllerUtils.tsrequireString,optionalString,optionalNumber,optionalBoolean,parseSortOrder,requireTeamId,requireUserId,requireUserEmail,requireFirstName,requireUserRolesMotivation
controllerUtils.tscontains validation functions used across every controller in the server, but had zero test coverage. These pure functions are ideal unit test candidates.Test Plan
cd server && npm testto verify all tests pass