Skip to content

Escalated Notifications Update#3468

Closed
Felix772 wants to merge 4 commits intobluewave-labs:developfrom
Felix772:develop
Closed

Escalated Notifications Update#3468
Felix772 wants to merge 4 commits intobluewave-labs:developfrom
Felix772:develop

Conversation

@Felix772
Copy link
Copy Markdown

@Felix772 Felix772 commented Apr 6, 2026

Describe your changes

Briefly describe the changes you made and their purpose.

I updated the monitor creation UI and validation to let users set up escalation rules — basically things like “after X minutes, notify this channel.” That’s now wired all the way through the system, including the frontend, backend types, and the Mongoose schema.
I also hooked escalation logic into the job engine. Now when an incident happens, it tracks how long the downtime has been, avoids sending duplicate alerts, and triggers escalation notifications at the right time. I added tracking for that too, so we store which escalations have already been sent.
On the backend side, I made a few reliability improvements — better MongoDB connection handling, a reusable SMTP setup for emails, added health checks, and support for persistent queue storage if needed.

Write your issue number after "Fixes "

Fixes #1

Please ensure all items are checked off before requesting a review. "Checked off" means you need to add an "x" character between brackets so they turn into checkmarks.

  • [ x] (Do not skip this or your PR will be closed) I deployed the application locally.
  • [ x] (Do not skip this or your PR will be closed) I have performed a self-review and testing of my code.
  • [x ] I have included the issue # in the PR.
  • I have added i18n support to visible strings (instead of <div>Add</div>, use):
const { t } = useTranslation();
<div>{t('add')}</div>
  • [x ] I have not included any files that are not related to my pull request, including package-lock and package-json if dependencies have not changed
  • [ x] I didn't use any hardcoded values (otherwise it will not scale, and will make it difficult to maintain consistency across the application).
  • [x ] I made sure font sizes, color choices etc are all referenced from the theme. I don't have any hardcoded dimensions.
  • [x ] My PR is granular and targeted to one specific feature.
  • [ x] I ran npm run format in server and client directories, which automatically formats your code.
  • [ x] I took a screenshot or a video and attached to this PR if there is a UI change.
Screenshot 2026-04-06 162935

@ajhollid
Copy link
Copy Markdown
Collaborator

ajhollid commented Apr 7, 2026

Hi @Felix772 ,

Thanks for taking the time to work on the project.

Can you please resubmit this PR as two separate PRs, one for the backend implementation and one for the frontend implemetnation?

We'll review the backend implementation first and make sure it behaves as expected, then we'll review the frontend implementation after that.

This helps us keep PR sizes down and makes PRs much easier to review for us.

It also appears you may have started from an older branch and their have been changes since, so we have some merge conflicts here. Please rebase your changes as well before reopening.

Thank you!

@ajhollid ajhollid closed this Apr 7, 2026
This was referenced Apr 7, 2026
@Felix772
Copy link
Copy Markdown
Author

Felix772 commented Apr 7, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement drop downs, colors, texts, tabs, dashboard and popup menus with MUI

3 participants