Escalated Notifications Update#3468
Closed
Felix772 wants to merge 4 commits intobluewave-labs:developfrom
Closed
Conversation
Collaborator
|
Hi @Felix772 , Thanks for taking the time to work on the project. Can you please resubmit this PR as two separate PRs, one for the backend implementation and one for the frontend implemetnation? We'll review the backend implementation first and make sure it behaves as expected, then we'll review the frontend implementation after that. This helps us keep PR sizes down and makes PRs much easier to review for us. It also appears you may have started from an older branch and their have been changes since, so we have some merge conflicts here. Please rebase your changes as well before reopening. Thank you! |
Author
|
… On Tue, Apr 7, 2026 at 1:02 PM Alexander Holliday ***@***.***> wrote:
*ajhollid* left a comment (bluewave-labs/Checkmate#3468)
<#3468 (comment)>
Hi @Felix772 <https://github.com/Felix772> ,
Thanks for taking the time to work on the project.
Can you please resubmit this PR as two separate PRs, one for the backend
implementation and one for the frontend implemetnation?
We'll review the backend implementation first and make sure it behaves as
expected, then we'll review the frontend implementation after that.
This helps us keep PR sizes down and makes PRs much easier to review for
us.
It also appears you may have started from an older branch and their have
been changes since, so we have some merge conflicts here. Please rebase
your changes as well before reopening.
Thank you!
—
Reply to this email directly, view it on GitHub
<#3468 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWCWO4FKD6CLSSAGX4BYHY34UUYBTAVCNFSM6AAAAACXOSTMYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEMBQHAZDQNBWHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Briefly describe the changes you made and their purpose.
I updated the monitor creation UI and validation to let users set up escalation rules — basically things like “after X minutes, notify this channel.” That’s now wired all the way through the system, including the frontend, backend types, and the Mongoose schema.
I also hooked escalation logic into the job engine. Now when an incident happens, it tracks how long the downtime has been, avoids sending duplicate alerts, and triggers escalation notifications at the right time. I added tracking for that too, so we store which escalations have already been sent.
On the backend side, I made a few reliability improvements — better MongoDB connection handling, a reusable SMTP setup for emails, added health checks, and support for persistent queue storage if needed.
Write your issue number after "Fixes "
Fixes #1
Please ensure all items are checked off before requesting a review. "Checked off" means you need to add an "x" character between brackets so they turn into checkmarks.
<div>Add</div>, use):npm run formatin server and client directories, which automatically formats your code.