feat: adding mobile/desktop pagespeed strategy#3470
feat: adding mobile/desktop pagespeed strategy#3470akashmannil wants to merge 5 commits intodevelopfrom
Conversation
|
Thanks for jumping on this so fast! Couple things Claude spotted and I want to mention, might make sense:
I think editing should be allowed - so I can just switch existing monitors to mobile without re-adding new ones and without paused old monitors for historical data. And strategy should be empty by default, only set for pagespeed. |
|
Thanks for the review @dmythro. PFB thought process for each of the mentioned pointers.
|
ajhollid
left a comment
There was a problem hiding this comment.
Some minor issues to resolve, but it generally looks good.
Allowing editing of the strategy type is a design decision; we can defer to @gorkem-bwl on that one.
My personal opinion is to agree with you that it should be immutable once set, as the historical data will be nonsensical if you switch strategies.
The precedent has been set for allowing these types of history-breaking changes, though, so I'll leave this one to @gorkem-bwl to make the call.
My take here is that user knows what he's doing, so we could agreeable for the user to edit that section. |
|
As a user I'd prefer to edit this. At least I hope you won't block editing strategy via API. I have many monitors and creating new for each and pause old ones is much more hassle than just switch to mobile and know that older data was desktop is fine with me. |
ajhollid
left a comment
There was a problem hiding this comment.
Looks pretty good. There's an error in the montor validation that will set strategy to non-pagespeed type monitors that needs to be fixed, I think we're done after that.
|
@ajhollid Default values removed and set only for pagespeed monitors. Please do let me know if this looks ok. Thanks! |
Adding Pagespeed desktop/mobile strategy.
Fixes #3453
Please ensure all items are checked off before requesting a review. "Checked off" means you need to add an "x" character between brackets so they turn into checkmarks.
<div>Add</div>, use):npm run formatin server and client directories, which automatically formats your code.