Security: Notification management endpoints lack explicit authentication/authorization middleware#3495
Closed
tuanaiseo wants to merge 1 commit intobluewave-labs:developfrom
Conversation
The notification routes expose create, test, read, update, and delete handlers without `verifyJWT` or role checks at route level. If these routes are mounted without a global auth guard, an unauthenticated or low-privileged caller could manage notification channels (including webhook-like destinations), leading to data exposure and abuse. Affected files: notificationRoute.ts Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
ajhollid
reviewed
Apr 13, 2026
Collaborator
ajhollid
left a comment
There was a problem hiding this comment.
Notification routes are secured at the config level in routes.ts
app.use("/api/v1/notifications", verifyJWT, notificationRoutes.getRouter());
Unless I'm missing something, this can be safely closed. Let me know if I have indeed missed something.
Collaborator
|
Closing as it is a non-issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The notification routes expose create, test, read, update, and delete handlers without
verifyJWTor role checks at route level. If these routes are mounted without a global auth guard, an unauthenticated or low-privileged caller could manage notification channels (including webhook-like destinations), leading to data exposure and abuse.Severity:
highFile:
server/src/routes/notificationRoute.tsSolution
Require authentication middleware (e.g.,
verifyJWT) and enforce authorization per action (e.g., owner/team checks,isAllowed(["admin","superadmin"])where appropriate) on all notification endpoints.Changes
server/src/routes/notificationRoute.ts(modified)Testing