docs: add environment variables reference guide#3539
docs: add environment variables reference guide#3539Smolcup wants to merge 1 commit intobluewave-labs:developfrom
Conversation
ajhollid
left a comment
There was a problem hiding this comment.
These docs are inaccurate, please review the source code
| | `REDIS_HOST` | Redis host | `localhost` | | ||
| | `REDIS_PORT` | Redis port | `6379` | |
| | `REDIS_HOST` | Redis host | `localhost` | | ||
| | `REDIS_PORT` | Redis port | `6379` | | ||
| | `TOKEN_TTL` | JWT token expiry | `99d` | | ||
| | `REFRESH_TOKEN_TTL` | Refresh token expiry | `7d` | |
There was a problem hiding this comment.
RERFRESH_TOKEN_TTL no longer used
| | Variable | Description | | ||
| |----------|-------------| | ||
| | `SYSTEM_EMAIL_ADDRESS` | From address for emails | | ||
| | `SMTP_HOST` | SMTP server host | | ||
| | `SMTP_PORT` | SMTP server port | | ||
| | `SMTP_USER` | SMTP username | | ||
| | `SMTP_PASSWORD` | SMTP password | |
| ## Optional Features | ||
|
|
||
| | Variable | Description | | ||
| |----------|-------------| | ||
| | `PAGESPEED_API_KEY` | Google PageSpeed API key | | ||
| | `DOCKER_HOST` | Docker daemon socket path | |
|
Thank you for your feedback, I'll get back to working on it! |
d555f1f to
6b43a41
Compare
|
I have updated the file accordingly, thank you for your work! |
ajhollid
left a comment
There was a problem hiding this comment.
There are some missing vars and some other minor changes to make, please see my comments in the code review.
Thanks!
|
|
||
| | Variable | Description | Default | | ||
| |----------|-------------|---------| | ||
| | `NODE_ENV` | Application environment | `development` | |
| | `NODE_ENV` | Application environment | `development` | | ||
| | `LOG_LEVEL` | Logging level | `debug` | | ||
| | `TOKEN_TTL` | JWT token expiry time | `99d` | | ||
| | `CLIENT_HOST` | Frontend URL | `http://localhost:5173` | |
|
|
||
| ## Notes | ||
|
|
||
| - The server reads these variables from `server/.env` |
There was a problem hiding this comment.
All vars are read from server/.env, this line seems to indicate that only JWT_SECRET and TOKEN_TTL are read from .env. This line can just be removed safely.
| # Environment Variables | ||
|
|
||
| This document describes the environment variables used by Checkmate server. | ||
|
|
There was a problem hiding this comment.
Missing the required client env vars
VITE_APP_API_BASE_URL
VITE_APP_CLIENT_HOST
|
Closing as inactive |
Describe your changes
Adds comprehensive documentation for all environment variables used by Checkmate server and client.
Write your issue number after "Fixes "
No issue was fixed, this is a documentation contribution.
Please ensure all items are checked off before requesting a review. "Checked off" means you need to add an "x" character between brackets so they turn into checkmarks.
<div>Add</div>, use):npm run formatin server and client directories, which automatically formats your code.