Skip to content

Commit 221827f

Browse files
authored
tests: move tests for TerminalWriter (#429)
2 parents 9482abe + f095967 commit 221827f

4 files changed

Lines changed: 11 additions & 7 deletions

File tree

src/_pytest/doctest.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
from _pytest._code.code import ExceptionInfo
2020
from _pytest._code.code import ReprFileLocation
2121
from _pytest._code.code import TerminalRepr
22-
from _pytest._io import TerminalWriter
2322
from _pytest.compat import safe_getattr
2423
from _pytest.compat import TYPE_CHECKING
2524
from _pytest.fixtures import FixtureRequest
@@ -31,6 +30,8 @@
3130
import doctest
3231
from typing import Type
3332

33+
from _pytest._io import TerminalWriter
34+
3435
DOCTEST_REPORT_CHOICE_NONE = "none"
3536
DOCTEST_REPORT_CHOICE_CDIFF = "cdiff"
3637
DOCTEST_REPORT_CHOICE_NDIFF = "ndiff"
@@ -136,10 +137,10 @@ def _is_doctest(config, path, parent):
136137
class ReprFailDoctest(TerminalRepr):
137138
def __init__(
138139
self, reprlocation_lines: Sequence[Tuple[ReprFileLocation, Sequence[str]]]
139-
):
140+
) -> None:
140141
self.reprlocation_lines = reprlocation_lines
141142

142-
def toterminal(self, tw: TerminalWriter) -> None:
143+
def toterminal(self, tw: "TerminalWriter") -> None:
143144
for reprlocation, lines in self.reprlocation_lines:
144145
for line in lines:
145146
tw.line(line)

src/_pytest/fixtures.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
from _pytest._code.code import FormattedExcinfo
1818
from _pytest._code.code import TerminalRepr
1919
from _pytest._code.source import getfslineno
20-
from _pytest._io import TerminalWriter
2120
from _pytest.compat import _format_args
2221
from _pytest.compat import _PytestWrapper
2322
from _pytest.compat import get_real_func
@@ -41,6 +40,7 @@
4140
from typing_extensions import Literal
4241

4342
from _pytest import nodes
43+
from _pytest._io import TerminalWriter
4444
from _pytest.main import Session
4545
from _pytest.runner import _RuntestPhase
4646

@@ -776,7 +776,7 @@ def __init__(self, filename, firstlineno, tblines, errorstring, argname):
776776
self.firstlineno = firstlineno
777777
self.argname = argname
778778

779-
def toterminal(self, tw: TerminalWriter) -> None:
779+
def toterminal(self, tw: "TerminalWriter") -> None:
780780
# tw.line("FixtureLookupError: %s" %(self.argname), red=True)
781781
for tbline in self.tblines:
782782
tw.line(tbline.rstrip())

src/_pytest/python.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
from _pytest._code import filter_traceback
2929
from _pytest._code.code import ExceptionInfo
3030
from _pytest._code.source import getfslineno
31-
from _pytest._io import TerminalWriter
3231
from _pytest._io.saferepr import saferepr
3332
from _pytest.compat import ascii_escaped
3433
from _pytest.compat import get_default_arg_names
@@ -42,6 +41,7 @@
4241
from _pytest.compat import safe_getattr
4342
from _pytest.compat import safe_isclass
4443
from _pytest.compat import STRING_TYPES
44+
from _pytest.compat import TYPE_CHECKING
4545
from _pytest.config import Config
4646
from _pytest.config import hookimpl
4747
from _pytest.deprecated import FUNCARGNAMES
@@ -57,6 +57,9 @@
5757
from _pytest.warning_types import PytestCollectionWarning
5858
from _pytest.warning_types import PytestUnhandledCoroutineWarning
5959

60+
if TYPE_CHECKING:
61+
from _pytest._io import TerminalWriter
62+
6063

6164
def pyobj_property(name):
6265
def get(self):
@@ -1382,7 +1385,7 @@ def _showfixtures_main(config, session):
13821385
tw.line()
13831386

13841387

1385-
def write_docstring(tw: TerminalWriter, doc: str, indent: str = " ") -> None:
1388+
def write_docstring(tw: "TerminalWriter", doc: str, indent: str = " ") -> None:
13861389
for line in doc.split("\n"):
13871390
tw.write(indent + line + "\n")
13881391

0 commit comments

Comments
 (0)