Skip to content

Commit 87900fc

Browse files
committed
Revert "tbstyle_given"
This reverts commit 9808c46.
1 parent 9808c46 commit 87900fc

2 files changed

Lines changed: 5 additions & 7 deletions

File tree

src/_pytest/config/__init__.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -782,7 +782,6 @@ def __init__(self, pluginmanager, *, invocation_params=None) -> None:
782782
)
783783

784784
self.option = argparse.Namespace()
785-
self._nondefault_options = set() # type: Set[str]
786785
self.invocation_params = invocation_params
787786

788787
_a = FILE_OR_DIR
@@ -896,10 +895,9 @@ def _processopt(self, opt: "Argument") -> None:
896895
for name in opt._short_opts + opt._long_opts:
897896
self._opt2dest[name] = opt.dest
898897

899-
if hasattr(self.option, opt.dest):
900-
self._nondefault_options.add(opt.dest)
901-
elif hasattr(opt, "default"):
902-
setattr(self.option, opt.dest, opt.default)
898+
if hasattr(opt, "default"):
899+
if not hasattr(self.option, opt.dest):
900+
setattr(self.option, opt.dest, opt.default)
903901

904902
@hookimpl(trylast=True)
905903
def pytest_load_initial_conftests(self, early_config):

src/_pytest/nodes.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -333,11 +333,11 @@ def _repr_failure_py(
333333
return excinfo.value.formatrepr()
334334

335335
# XXX should excinfo.getrepr record all data and toterminal() process it?
336+
# XXX: does not distinguish between default/unset and --tb=auto.
336337
tbstyle = self.config.option.tbstyle
337338
verbosity = self.config.option.verbose
338339
if fulltrace:
339-
tbstyle_given = "tbstyle" in self.config._nondefault_options
340-
style = tbstyle if tbstyle_given else "long" # type: _TracebackStyle
340+
style = "long" if tbstyle == "auto" else tbstyle # type: _TracebackStyle
341341
else:
342342
if tbstyle == "auto":
343343
if default_style is None:

0 commit comments

Comments
 (0)