Rebase upstram tests file

Author: welcoMattic

test/test-installation-components.js

@@ -1813,87 +1813,90 @@ async function runTests() {
   // ============================================================
   console.log(`${colors.yellow}Test Suite 31: Mistral Vibe CLI Native Skills${colors.reset}\n`);
 
-  let tempProjectDir31;
-  let installedBmadDir31;
+  let tempProjectDirMistral;
+  let installedBmadDirMistral;
   try {
     clearCache();
-    const platformCodes31 = await loadPlatformCodes();
-    const mistralInstaller = platformCodes31.platforms.mistral?.installer;
+    const platformCodesMistral = await loadPlatformCodes();
+    const mistralInstaller = platformCodesMistral.platforms.mistral?.installer;
 
     assert(mistralInstaller?.target_dir === '.vibe/skills', 'Mistral Vibe target_dir uses native skills path');
     assert(mistralInstaller?.skill_format === true, 'Mistral Vibe installer enables native skill output');
     assert(mistralInstaller?.template_type === 'default', 'Mistral Vibe installer uses default skill template');
     assert(mistralInstaller?.legacy_targets === undefined, 'Mistral Vibe installer has no legacy_targets');
 
-    tempProjectDir31 = await fs.mkdtemp(path.join(os.tmpdir(), 'bmad-mistral-test-'));
-    installedBmadDir31 = await createTestBmadFixture();
+    tempProjectDirMistral = await fs.mkdtemp(path.join(os.tmpdir(), 'bmad-mistral-test-'));
+    installedBmadDirMistral = await createTestBmadFixture();
 
-    const ideManager31 = new IdeManager();
-    await ideManager31.ensureInitialized();
+    const ideManagerMistral = new IdeManager();
+    await ideManagerMistral.ensureInitialized();
 
     // Verify Mistral Vibe is selectable in an available IDEs list
-    const availableIdes31 = ideManager31.getAvailableIdes();
+    const availableIdesMistral = ideManagerMistral.getAvailableIdes();
     assert(
-      availableIdes31.some((ide) => ide.value === 'mistral'),
+      availableIdesMistral.some((ide) => ide.value === 'mistral'),
       'Mistral Vibe appears in available IDEs list',
     );
 
     // Verify Mistral Vibe is NOT detected before install
-    const detectedBefore31 = await ideManager31.detectInstalledIdes(tempProjectDir31);
-    assert(!detectedBefore31.includes('mistral'), 'Mistral Vibe is not detected before install');
+    const detectedBeforeMistral = await ideManagerMistral.detectInstalledIdes(tempProjectDirMistral);
+    assert(!detectedBeforeMistral.includes('mistral'), 'Mistral Vibe is not detected before install');
 
-    const result31 = await ideManager31.setup('mistral', tempProjectDir31, installedBmadDir31, {
+    const resultMistral = await ideManagerMistral.setup('mistral', tempProjectDirMistral, installedBmadDirMistral, {
       silent: true,
       selectedModules: ['bmm'],
     });
 
-    assert(result31.success === true, 'Mistral Vibe setup succeeds against temp project');
+    assert(resultMistral.success === true, 'Mistral Vibe setup succeeds against temp project');
 
     // Verify Mistral Vibe IS detected after install
-    const detectedAfter31 = await ideManager31.detectInstalledIdes(tempProjectDir31);
-    assert(detectedAfter31.includes('mistral'), 'Mistral Vibe is detected after install');
+    const detectedAfterMistral = await ideManagerMistral.detectInstalledIdes(tempProjectDirMistral);
+    assert(detectedAfterMistral.includes('mistral'), 'Mistral Vibe is detected after install');
 
-    const skillFile31 = path.join(tempProjectDir31, '.vibe', 'skills', 'bmad-master', 'SKILL.md');
-    assert(await fs.pathExists(skillFile31), 'Mistral Vibe install writes SKILL.md directory output');
+    const skillFileMistral = path.join(tempProjectDirMistral, '.vibe', 'skills', 'bmad-master', 'SKILL.md');
+    assert(await fs.pathExists(skillFileMistral), 'Mistral Vibe install writes SKILL.md directory output');
 
     // Parse YAML frontmatter between --- markers
-    const skillContent31 = await fs.readFile(skillFile31, 'utf8');
-    const fmMatch31 = skillContent31.match(/^---\n([\s\S]*?)\n---\n?([\s\S]*)$/);
-    assert(fmMatch31, 'Mistral Vibe SKILL.md contains valid frontmatter delimiters');
+    const skillContentMistral = await fs.readFile(skillFileMistral, 'utf8');
+    const fmMatchMistral = skillContentMistral.match(/^---\n([\s\S]*?)\n---\n?([\s\S]*)$/);
+    assert(fmMatchMistral, 'Mistral Vibe SKILL.md contains valid frontmatter delimiters');
 
-    const frontmatter31 = fmMatch31[1];
-    const body31 = fmMatch31[2];
+    const frontmatterMistral = fmMatchMistral[1];
+    const bodyMistral = fmMatchMistral[2];
 
     // Verify the name in the frontmatter matches the directory name
-    const fmName31 = frontmatter31.match(/^name:\s*(.+)$/m);
-    assert(fmName31 && fmName31[1].trim() === 'bmad-master', 'Mistral Vibe skill name frontmatter matches directory name exactly');
+    const fmNameMistral = frontmatterMistral.match(/^name:\s*(.+)$/m);
+    assert(
+      fmNameMistral && fmNameMistral[1].trim() === 'bmad-master',
+      'Mistral Vibe skill name frontmatter matches directory name exactly',
+    );
 
     // Verify description exists and is non-empty
-    const fmDesc31 = frontmatter31.match(/^description:\s*(.+)$/m);
-    assert(fmDesc31 && fmDesc31[1].trim().length > 0, 'Mistral Vibe skill description frontmatter is present and non-empty');
+    const fmDescMistral = frontmatterMistral.match(/^description:\s*(.+)$/m);
+    assert(fmDescMistral && fmDescMistral[1].trim().length > 0, 'Mistral Vibe skill description frontmatter is present and non-empty');
 
     // Verify frontmatter contains only name and description keys
-    const fmKeys31 = [...frontmatter31.matchAll(/^([a-zA-Z0-9_-]+):/gm)].map((m) => m[1]);
+    const fmKeysMistral = [...frontmatterMistral.matchAll(/^([a-zA-Z0-9_-]+):/gm)].map((m) => m[1]);
     assert(
-      fmKeys31.length === 2 && fmKeys31.includes('name') && fmKeys31.includes('description'),
+      fmKeysMistral.length === 2 && fmKeysMistral.includes('name') && fmKeysMistral.includes('description'),
       'Mistral Vibe skill frontmatter contains only name and description keys',
     );
 
     // Verify body content is non-empty
-    assert(body31.trim().length > 0, 'Mistral Vibe skill body content is non-empty');
+    assert(bodyMistral.trim().length > 0, 'Mistral Vibe skill body content is non-empty');
 
     // Reinstall/upgrade: run setup again over existing output
-    const result31b = await ideManager31.setup('mistral', tempProjectDir31, installedBmadDir31, {
+    const resultMistralb = await ideManagerMistral.setup('mistral', tempProjectDirMistral, installedBmadDirMistral, {
       silent: true,
       selectedModules: ['bmm'],
     });
-    assert(result31b.success === true, 'Mistral Vibe reinstall/upgrade succeeds over existing skills');
-    assert(await fs.pathExists(skillFile31), 'Mistral Vibe reinstall preserves SKILL.md output');
+    assert(resultMistralb.success === true, 'Mistral Vibe reinstall/upgrade succeeds over existing skills');
+    assert(await fs.pathExists(skillFileMistral), 'Mistral Vibe reinstall preserves SKILL.md output');
   } catch (error) {
     assert(false, 'Mistral Vibe native skills test succeeds', error.message);
   } finally {
-    if (tempProjectDir31) await fs.remove(tempProjectDir31).catch(() => {});
-    if (installedBmadDir31) await fs.remove(installedBmadDir31).catch(() => {});
+    if (tempProjectDirMistral) await fs.remove(tempProjectDirMistral).catch(() => {});
+    if (installedBmadDirMistral) await fs.remove(installedBmadDirMistral).catch(() => {});
   }
 
   console.log('');