fix: reconcile story and sprint status on closeout

Author: dickymoore

src/bmm/workflows/4-implementation/code-review/workflow.md

@@ -258,11 +258,20 @@ Load config from `{project-root}/_bmad/bmm/config.yaml` and resolve:
     <output>ℹ️ Story status updated (no sprint tracking configured)</output>
   </check>
 
+  <!-- Final reconciliation - story markdown and tracker must agree -->
+  <action>Re-open the story file after saving and verify the top-level Status field equals {{new_status}}</action>
+  <check if="{sprint_status} file exists AND {{current_sprint_status}} != 'no-sprint-tracking'">
+    <action>Re-open {sprint_status} after saving and verify development_status[{{story_key}}] equals {{new_status}}</action>
+  </check>
+  <action if="story file status does not equal {{new_status}}">HALT - Closeout reconciliation failed: story markdown status drift detected</action>
+  <action if="{sprint_status} file exists AND {{current_sprint_status}} != 'no-sprint-tracking' AND development_status[{{story_key}}] does not equal {{new_status}}">HALT - Closeout reconciliation failed: sprint-status drift detected</action>
+
   <output>**✅ Review Complete!**
 
     **Story Status:** {{new_status}}
     **Issues Fixed:** {{fixed_count}}
     **Action Items Created:** {{action_count}}
+    **Reconciled:** story markdown and sprint tracker agree on {{new_status}}
 
     {{#if new_status == "done"}}Code review complete!{{else}}Address the action items and continue development.{{/if}}
   </output>

src/bmm/workflows/4-implementation/sprint-status/workflow.md

@@ -120,6 +120,7 @@ Enter corrections (e.g., "1=in-progress, 2=backlog") or "skip" to continue witho
 
 - IF any story has status "review": suggest `/bmad:bmm:workflows:code-review`
 - IF any story has status "in-progress" AND no stories have status "ready-for-dev": recommend staying focused on active story
+- IF any story markdown file top-level `Status:` does not match its `development_status` entry: warn "story/tracker status drift detected"
 - IF all epics have status "backlog" AND no stories have status "ready-for-dev": prompt `/bmad:bmm:workflows:create-story`
 - IF `last_updated` timestamp is more than 7 days old (or `last_updated` is missing, fall back to `generated`): warn "sprint-status.yaml may be stale"
 - IF any story key doesn't match an epic pattern (e.g., story "5-1-..." but no "epic-5"): warn "orphaned story detected"
@@ -260,6 +261,14 @@ If the command targets a story, set `story_key={{next_story_id}}` when prompted.
   <action>Return</action>
   </check>
 
+<action>For each story entry in development_status, open the matching story markdown file under {implementation_artifacts} and compare its top-level `Status:` value with the tracker status when the tracker status is `review` or `done`</action>
+<check if="any story markdown status does not match its tracker status for review/done stories">
+<template-output>is_valid = false</template-output>
+<template-output>error = "Story/tracker status drift detected: {{drift_entries}}"</template-output>
+<template-output>suggestion = "Reconcile story markdown Status fields with sprint-status.yaml before closeout"</template-output>
+<action>Return</action>
+</check>
+
 <template-output>is_valid = true</template-output>
 <template-output>message = "sprint-status.yaml valid: metadata complete, all statuses recognized"</template-output>
 </step>

test/test-closeout-reconciliation.js

@@ -0,0 +1,78 @@
+/**
+ * Closeout reconciliation workflow tests
+ *
+ * Ensures the implementation workflows explicitly enforce reconciliation
+ * between story markdown Status fields and sprint-status.yaml before closeout.
+ *
+ * Usage: node test/test-closeout-reconciliation.js
+ */
+
+import fs from 'node:fs';
+
+const colors = {
+  reset: '\u001B[0m',
+  green: '\u001B[32m',
+  red: '\u001B[31m',
+  cyan: '\u001B[36m',
+  dim: '\u001B[2m',
+};
+
+let passed = 0;
+let failed = 0;
+
+function assert(condition, testName, errorMessage = '') {
+  if (condition) {
+    console.log(`${colors.green}✓${colors.reset} ${testName}`);
+    passed++;
+  } else {
+    console.log(`${colors.red}✗${colors.reset} ${testName}`);
+    if (errorMessage) {
+      console.log(`  ${colors.dim}${errorMessage}${colors.reset}`);
+    }
+    failed++;
+  }
+}
+
+const codeReview = fs.readFileSync(
+  'src/bmm/workflows/4-implementation/code-review/workflow.md',
+  'utf8',
+);
+const sprintStatus = fs.readFileSync(
+  'src/bmm/workflows/4-implementation/sprint-status/workflow.md',
+  'utf8',
+);
+
+console.log(`\n${colors.cyan}Closeout Reconciliation Tests${colors.reset}\n`);
+
+assert(
+  codeReview.includes('Re-open the story file after saving and verify the top-level Status field equals {{new_status}}'),
+  'code-review reopens the story file to verify final status reconciliation',
+);
+
+assert(
+  codeReview.includes('Closeout reconciliation failed: story markdown status drift detected'),
+  'code-review halts when story markdown status drifts',
+);
+
+assert(
+  codeReview.includes('Closeout reconciliation failed: sprint-status drift detected'),
+  'code-review halts when sprint-status drifts',
+);
+
+assert(
+  codeReview.includes('story markdown and sprint tracker agree on {{new_status}}'),
+  'code-review reports successful reconciliation in the completion summary',
+);
+
+assert(
+  sprintStatus.includes('story/tracker status drift detected'),
+  'sprint-status warns about story/tracker drift',
+);
+
+assert(
+  sprintStatus.includes('For each story entry in development_status, open the matching story markdown file'),
+  'sprint-status validate mode checks story files against tracker state',
+);
+
+console.log(`\n${passed} passed, ${failed} failed\n`);
+process.exit(failed > 0 ? 1 : 0);