feat(skills): add discovery rigor and workflow contract support#2237
Closed
edamlmmv wants to merge 2 commits intobmad-code-org:mainfrom
Closed
feat(skills): add discovery rigor and workflow contract support#2237edamlmmv wants to merge 2 commits intobmad-code-org:mainfrom
edamlmmv wants to merge 2 commits intobmad-code-org:mainfrom
Conversation
- add discovery rigor and memory manager skill flows plus supporting resources - add workflow contract skill scaffolding and update related module metadata - tighten validation, installation coverage, and local ignore rules for contribution hygiene
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis pull request introduces a comprehensive workflow-contract creation skill, an extensive discovery-rigor framework with specialized agents and domain resources, a new memory-manager skill for state persistence, and refactors skill/agent manifest discovery to prevent nested traversal. Additionally, it enhances story templates with Exit Criteria and Rollback Boundary sections, updates dev-story and code-review workflows to enforce immutability of frozen content, and refines the distillator and adversarial-review skills. Changes
Sequence Diagram(s)sequenceDiagram
participant User as User/Context
participant Step1 as Step 1: Classify
participant Step2 as Step 2: Interview
participant Step3 as Step 3: Blind-Spots
participant Step4 as Step 4: Research
participant Step5 as Step 5: Handoff
participant StateLedger as State Ledger
User->>Step1: Start Discovery Rigor
Step1->>Step1: Load classification guide
Step1->>User: Ask: Activity/Tier/Convergence
User-->>Step1: Provide classification
Step1->>StateLedger: Record classification
alt Activity=Solve & Tier=Quick
Step1->>Step1: Route to Quick Handoff
else Other paths
Step1->>Step2: Route to Interview
end
Step2->>Step2: Load domain fragments
Step2->>User: Ask 3-6 decision questions (2-3 batches)
User-->>Step2: Provide responses
Step2->>StateLedger: Update with findings/counter
Step2->>Step3: Route to Blind-Spots
Step3->>Step3: Load system reality categories
Step3->>User: Identify blind-spots per category (≤5 at a time)
User-->>Step3: Triage blind-spots
Step3->>StateLedger: Record blind-spots/counter
alt Counter ≥2 or convergence evidence gap
Step3->>Step4: Route to Research
else Sufficient depth
Step3->>Step5: Route to Handoff
end
Step4->>Step4: Build research plan from gaps
Step4->>User: Investigate gaps / confirm resolution
User-->>Step4: Provide evidence/confirm
Step4->>StateLedger: Reset counter, record research
Step4->>Step5: Route to Handoff
Step5->>Step5: Verify completeness gates
Step5->>Step5: Compile standardized Discovery Context
Step5->>User: Present findings/recommend downstream
Step5->>StateLedger: Record final state + Skill
Step5->>User: Complete & Handoff
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- rename the discovery-rigor agent entrypoint from thinking-protocol - remove the obsolete distillate artifact and reset the installation test file
Author
|
Reopening to include the second commit from the fork branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a discovery-rigor core skill and a workflow-contract skill, plus supporting memory-manager and guidance updates so BMAD workflows can start from explicit discovery state and carry cleaner handoffs.
Why
Recent workflow changes needed a more structured discovery entry point, clearer contract authoring guidance, and validation behavior that matches current skill packaging. This keeps the skill surface more consistent and recovery-friendly for contributors and downstream agents.
How
Testing
Ran
npm run qualitysuccessfully.