fix(installer): remove bmad-help from Copilot Custom Agents picker

[jheyworth]

Problem statement

PR #2324 added bmad-help to the GitHub Copilot Custom Agents picker. On reflection this was a mistake — bmad-help is not a true agent (it's the meta-help skill that every persona agent already advertises on activation), so its picker entry is redundant and confusing.

Proposed solution

This PR removes bmad-help from the GitHub Copilot Custom Agents picker.

Files changed

• tools/installer/ide/_config-driven.js — installer code that controls which skills appear in the picker
• test/test-installation-components.js — flips the bmad-help assertion from inclusion to exclusion

Tests

npm run lint, npm run format:check, npm run test:install all pass locally.

Refs #2324

[augmentcode]

🤖 Augment PR Summary

Summary: This PR removes the special-case allowlist that forced bmad-help to appear in GitHub Copilot’s Custom Agents picker.

Changes:

• Deleted ALWAYS_AGENT_IDS and the corresponding inclusion check in isAgentSkill, making [agent] in customize.toml the only signal for picker inclusion.
• Updated Suite 17’s fixture and assertions to expect bmad-help to be excluded when it has no customize.toml.
• Adjusted inline documentation/comments in both the installer logic and the test to reflect the toml-driven filtering.

Technical Notes: Copilot picker entries are now strictly derived from the presence of an [agent] section in each skill’s source customize.toml.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR removes special-case handling for the bmad-help skill from agent skill detection logic and updates corresponding test expectations to rely on toml-driven filtering instead of a hardcoded exception list.

Changes

Cohort / File(s)	Summary
Agent Detection Logic tools/installer/ide/_config-driven.js	Removed ALWAYS_AGENT_IDS set and early-return check from isAgentSkill() so that agent skill detection is now based solely on whether the skill's customize.toml contains an [agent] section.
Test Updates test/test-installation-components.js	Updated fixture metadata and assertions to expect bmad-help to be excluded from .github/agents/ via toml-driven filtering rather than included via the removed ALWAYS_AGENT_IDS exception list; updated inline comments to reflect the new behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• PR #1932 — Modifies installer agent-detection logic and test expectations in the same files (_config-driven.js and test-installation-components.js).

Suggested reviewers

• bmadcode

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the primary change: removing bmad-help from the Copilot Custom Agents picker, which aligns with the main objective of the PR.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The pull request description clearly relates to the changeset, explaining the removal of bmad-help from the Copilot picker and referencing the specific files modified.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}