feat: Add DevOps Lead Persona Riley for IaC and CI/CD (#2187)#2567
Open
ogormans-deptstack wants to merge 1 commit into
Open
feat: Add DevOps Lead Persona Riley for IaC and CI/CD (#2187)#2567ogormans-deptstack wants to merge 1 commit into
ogormans-deptstack wants to merge 1 commit into
Conversation
…2187) - Created bmad-agent-devops SKILL.md and customize.toml - Added Riley to module.yaml agent roster - Registered bmad-create-infrastructure and bmad-create-pipeline in module-help.csv
📝 WalkthroughWalkthroughThis PR adds a new DevOps Lead agent persona named "Riley" to the bmad-skills framework. It introduces a SKILL.md defining activation, persona, and menu dispatch behavior, a customize.toml with configuration and menu mappings, and registers the new agent in module.yaml's roster. ChangesDevOps Lead Agent Persona
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/bmm-skills/3-solutioning/bmad-agent-devops/SKILL.md (1)
19-76: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winSync the docs with Riley’s new activation contract.
This adds user-facing activation flow and menu dispatch behavior; please update the relevant docs page under
docs/so the new persona and config contract are documented. As per path instructions,src/**source changes should be reflected in the relevant docs pages.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/bmm-skills/3-solutioning/bmad-agent-devops/SKILL.md` around lines 19 - 76, Update the relevant docs page under docs/ to document Riley’s new activation contract introduced in SKILL.md, including the ordered activation steps in On Activation, the required config sources and placeholders used in Step 5, the greeting/prefix behavior in Step 6, and the menu dispatch logic in Step 8. Make sure the docs mention the persona layering, persistent facts loading, and the rule that an initial user intent can skip the menu and dispatch directly; use the existing SKILL.md section headings and terms like activation_steps_prepend, activation_steps_append, agent.menu, and bmad-help so the docs stay aligned with the source behavior.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/bmm-skills/3-solutioning/bmad-agent-devops/customize.toml`:
- Around line 58-66: The menu entries in agent.menu for codes II and CD are
pointing to missing skills, so gate them until the target implementations exist.
Either add the referenced skills bmad-create-infrastructure and
bmad-create-pipeline first, or remove/hide these entries in customize.toml so
the dispatch in agent.menu does not reference unavailable targets.
---
Nitpick comments:
In `@src/bmm-skills/3-solutioning/bmad-agent-devops/SKILL.md`:
- Around line 19-76: Update the relevant docs page under docs/ to document
Riley’s new activation contract introduced in SKILL.md, including the ordered
activation steps in On Activation, the required config sources and placeholders
used in Step 5, the greeting/prefix behavior in Step 6, and the menu dispatch
logic in Step 8. Make sure the docs mention the persona layering, persistent
facts loading, and the rule that an initial user intent can skip the menu and
dispatch directly; use the existing SKILL.md section headings and terms like
activation_steps_prepend, activation_steps_append, agent.menu, and bmad-help so
the docs stay aligned with the source behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 649e605a-0c79-47bc-a626-a726725b5e44
⛔ Files ignored due to path filters (1)
src/bmm-skills/module-help.csvis excluded by!**/*.csv
📒 Files selected for processing (3)
src/bmm-skills/3-solutioning/bmad-agent-devops/SKILL.mdsrc/bmm-skills/3-solutioning/bmad-agent-devops/customize.tomlsrc/bmm-skills/module.yaml
Comment on lines
+58
to
+66
| [[agent.menu]] | ||
| code = "II" | ||
| description = "Design Infrastructure-as-Code (IaC) specifications and workflows" | ||
| skill = "bmad-create-infrastructure" | ||
|
|
||
| [[agent.menu]] | ||
| code = "CD" | ||
| description = "Design CI/CD pipelines, promotion gates, and deployment strategies" | ||
| skill = "bmad-create-pipeline" |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
rg -n 'bmad-create-(infrastructure|pipeline)' srcRepository: bmad-code-org/BMAD-METHOD
Length of output: 815
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Find any files or directories that could implement or register the two skills.
git ls-files | rg 'bmad-create-(infrastructure|pipeline)|create-(infrastructure|pipeline)|infrastructure|pipeline'
# Also inspect nearby skill directories under src for matching names.
fd -a 'bmad-create-(infrastructure|pipeline)|create-(infrastructure|pipeline)' src || trueRepository: bmad-code-org/BMAD-METHOD
Length of output: 163
Gate II/CD until the target skills exist. These menu items point to bmad-create-infrastructure and bmad-create-pipeline, but there are no tracked implementations for either target yet. Add the skills first or hide these entries to avoid broken dispatch.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/bmm-skills/3-solutioning/bmad-agent-devops/customize.toml` around lines
58 - 66, The menu entries in agent.menu for codes II and CD are pointing to
missing skills, so gate them until the target implementations exist. Either add
the referenced skills bmad-create-infrastructure and bmad-create-pipeline first,
or remove/hide these entries in customize.toml so the dispatch in agent.menu
does not reference unavailable targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Introduces a dedicated DevOps Lead persona ("Riley") to fill the infrastructure and deployment gap in the agent roster.
Why
Currently, infrastructure and deployment topics are handled only superficially by the Architect. This dedicated persona handles infrastructure-as-code, CI/CD pipeline design, deployment strategies, and pipeline security.
Resolves #2187
How
bmad-agent-devopsSKILL.md and customize.toml insrc/bmm-skills/3-solutioning/src/bmm-skills/module.yamlbmad-create-infrastructureandbmad-create-pipeline) insrc/bmm-skills/module-help.csvTesting
npm run validate:refsand test suite (npm test) locally