fix: read version from root package.json in installer#837
Closed
fix: read version from root package.json in installer#837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/installer/bin/bmad.jsto always read version from rootpackage.jsontools/installer/package.jsonto match root version (4.44.2)Problem
When running
npx bmad-method@latest install, the installer was displaying version 4.43.0 even though 4.44.2 was published. This was due to:tools/installer/bin/bmad.jsreading fromtools/installer/package.jsontools/installer/package.jsonhaving a hardcoded version (4.43.0)Solution
Updated the version loading logic to always read from the root
package.json, ensuring the displayed version matches the published version.Test plan
node tools/installer/bin/bmad.js --version- now shows 4.44.2Related to
manifest-generator.js