Commit 02152d4
committed
fix: address PR #76 bot review, add Conventions section, drop {skill-root} ban
Bot findings addressed
- quality-analysis.md (agent/workflow): add L8/L7 to the "without
pre-pass" scanner lists so the new customization-surface scanner
actually runs.
- quality-dimensions.md (agent/workflow): update dimension counts
(Seven -> Eight; agent-side: Eight plus a ninth memory-only
Sanctum Architecture).
- quality-dimensions.md (agent): realign the Metadata validity rule
with standard-fields.md -- name is optional (empty string valid),
not required for stateless agents.
- standard-fields.md (agent): fix invalid TOML in the
first-breath-name example; split `[agents.<code>]` and
`name = "..."` across two lines in a fenced toml block.
- create-module.md (module): legacy-agent detection now accepts
`agent-` as a segment anywhere in the skill name, not just a
prefix (so `cis-agent-analyst` is picked up).
Terminology
- agent-memory-and-personalization.md, what-are-bmad-agents.md:
replace confusing "opt-out by default" phrasing with "disabled by
default" for the memory/autonomous customize.toml override surface.
Polish
- make-a-skill-customizable.md: align example glob name with the
canonical `project-context.md` (was `campaign-context`).
- SKILL-template-bootloader.md: replace ambiguous "after the routing
below dispatches" with explicit timing ("after config and sanctum
load, after routing dispatches, before user input"); also clarify
`file:` prefix glob expansion and missing-file handling.
- SKILL-template.md (agent): same `file:` prefix clarification.
- what-are-workflows.md: name all three override layers explicitly
(skill-root customize.toml + team + user) instead of the ambiguous
"three-layer model" phrasing that only listed two.
Docs accurate to bmm
- module-configuration.md: clarify that authors still write
module.yaml as source of truth, and the installer flows module-level
answers and the `agents:` roster into `_bmad/config.toml`
(+ config.user.toml) at the project root. Keeps alignment with bmm
PR #2285 central config.
Remove {skill-root} restriction
- skill-authoring-best-practices.md, builder-commands.md: drop the
"Never use {skill-root}" language. The token is supported and
resolves to the skill's installed directory; whether to use it is
up to the author.
New Conventions section in emitted skills
- SKILL-template.md (agent/workflow), SKILL-template-bootloader.md
(agent): add a `## Conventions` block listing the path tokens the
emitted skill uses: bare paths, {skill-root}, {project-root},
{skill-name}. Mirrors the bmm stateless-skill convention so readers
hit the vocabulary before it appears under On Activation.1 parent 43a0891 commit 02152d4
16 files changed
Lines changed: 47 additions & 17 deletions
File tree
- docs
- explanation
- how-to
- reference
- skills
- bmad-agent-builder
- assets
- references
- bmad-module-builder/references
- bmad-workflow-builder
- assets
- references
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
47 | 49 | | |
48 | 50 | | |
49 | 51 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
| 92 | + | |
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
| 67 | + | |
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
202 | | - | |
| 202 | + | |
203 | 203 | | |
204 | 204 | | |
205 | 205 | | |
| |||
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
24 | 31 | | |
25 | 32 | | |
26 | 33 | | |
| |||
30 | 37 | | |
31 | 38 | | |
32 | 39 | | |
33 | | - | |
| 40 | + | |
34 | 41 | | |
35 | 42 | | |
36 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
33 | 40 | | |
34 | 41 | | |
35 | 42 | | |
| |||
45 | 52 | | |
46 | 53 | | |
47 | 54 | | |
48 | | - | |
| 55 | + | |
49 | 56 | | |
50 | 57 | | |
51 | 58 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| |||
0 commit comments