fix: addressed PR comments

Author: muratkeremozcan

CHANGELOG.md

@@ -9,6 +9,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- NFR workflow boundary clarified: `test-design` now owns NFR planning (thresholds, planned evidence, NFR-derived risks) and `nfr-assess` is reframed as NFR Evidence Audit — evaluating implementation evidence against planned thresholds after code exists.
+- `nfr-assess` step-02 now checks for an existing `test-design` NFR plan first and uses it as the primary threshold source, falling back to raw documents only for missing or UNKNOWN thresholds.
+- TEA agent menu gains a `GATE` routing intent that guides users through the release gate sequence (optional test-review → optional nfr-assess → trace Phase 2 gate) without merging those workflows.
+- NFR domains in `nfr-assess` corrected from "maintainability" to "scalability" to match the four parallel subagent domains (security, performance, reliability, scalability).
+- TEA phase table updated: `nfr-assess` marked optional at the Release phase.
+- NFR planning items in `test-design` step-05 output checklist conditioned on NFR scope.
+- Engagement models table: TEA Solo row for NFR Evidence Audit updated from No to Optional.
 - GitHub Actions workflow dependencies upgraded to Node 24-compatible major versions:
   - `actions/checkout@v5`
   - `actions/setup-node@v6`

docs/explanation/tea-overview.md

@@ -222,7 +222,7 @@ TEA spans multiple phases (Phase 3, Phase 4, and the release gate). Most BMM age
 | **Phase 2**  | (none)                                                    | -                | Planning phase - PM defines FRs/NFRs                            |
 | **Phase 3**  | `test-design` (system-level), `framework`, `ci`           | Once per project | System testability, NFR planning, and test infrastructure setup |
 | **Phase 4**  | `test-design`, `atdd`, `automate`, `test-review`, `trace` | Per epic/story   | Test planning per epic, then per-story testing                  |
-| **Release**  | `nfr-assess`, `trace` (Phase 2: gate)                     | Per epic/release | NFR evidence audit and go/no-go decision                        |
+| **Release**  | `nfr-assess` (optional), `trace` (Phase 2: gate)          | Per epic/release | Optional NFR evidence audit; go/no-go gate decision             |
 
 **Note**: `trace` is a two-phase workflow: Phase 1 (traceability) + Phase 2 (gate decision). This reduces cognitive load while maintaining natural workflow.
 

src/workflows/testarch/bmad-testarch-nfr/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: bmad-testarch-nfr
-description: 'Audit NFR evidence for performance, security, reliability, and maintainability. Use when implementation evidence exists and the user says "audit NFR evidence", "audit NFRs", or "evaluate non-functional requirements"'
+description: 'Audit NFR evidence for performance, security, reliability, and scalability. Use when implementation evidence exists and the user says "audit NFR evidence", "audit NFRs", or "evaluate non-functional requirements"'
 ---
 
 # NFR Evidence Audit

src/workflows/testarch/bmad-testarch-nfr/workflow.yaml

@@ -1,7 +1,7 @@
 # Test Architect workflow: bmad-testarch-nfr
 name: bmad-testarch-nfr
 # prettier-ignore
-description: 'Audit NFR evidence for performance, security, reliability, and maintainability. Use when implementation evidence exists and the user says "lets assess NFRs", "audit NFR evidence", or "evaluate non-functional requirements"'
+description: 'Audit NFR evidence for performance, security, reliability, and scalability. Use when implementation evidence exists and the user says "lets assess NFRs", "audit NFR evidence", or "evaluate non-functional requirements"'
 
 # Critical variables from config
 config_source: "{project-root}/_bmad/tea/config.yaml"
@@ -21,7 +21,7 @@ template: "./nfr-report-template.md"
 # Variables and inputs
 variables:
   # NFR category assessment (defaults to all categories)
-  custom_nfr_categories: "" # Optional additional categories beyond standard (security, performance, reliability, maintainability)
+  custom_nfr_categories: "" # Optional additional categories beyond standard (security, performance, reliability, scalability)
 
 # Output configuration
 default_output_file: "{test_artifacts}/nfr-assessment.md"

src/workflows/testarch/bmad-testarch-test-design/steps-c/step-05-generate-output.md

@@ -130,9 +130,9 @@ Epic-level mode remains single-worker by default (one output artifact).
 Ensure the outputs include:
 
 - Risk assessment matrix
-- NFR planning summary (thresholds, missing thresholds, planned evidence, and NFR-derived risks)
+- NFR planning summary (thresholds, missing thresholds, planned evidence, and NFR-derived risks) — when NFRs are in scope
 - Coverage matrix and priorities
-- NFR coverage and planned evidence mapping
+- NFR coverage and planned evidence mapping — when NFRs are in scope
 - Execution strategy
 - Resource estimates (ranges)
 - Quality gate criteria