Merge pull request #107 from bmad-code-org/fix/nfr-planning-in-test-design

fix: neft planning in test design

Author: muratkeremozcan

CHANGELOG.md

@@ -9,6 +9,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- NFR workflow boundary clarified: `test-design` now owns NFR planning (thresholds, planned evidence, NFR-derived risks) and `nfr-assess` is reframed as NFR Evidence Audit — evaluating implementation evidence against planned thresholds after code exists.
+- `nfr-assess` step-02 now checks for an existing `test-design` NFR plan first and uses it as the primary threshold source, falling back to raw documents only for missing or UNKNOWN thresholds.
+- TEA agent menu gains a `GATE` routing intent that guides users through the release gate sequence (optional test-review → optional nfr-assess → trace Phase 2 gate) without merging those workflows.
+- NFR domains in `nfr-assess` corrected from "maintainability" to "scalability" to match the four parallel subagent domains (security, performance, reliability, scalability).
+- TEA phase table updated: `nfr-assess` marked optional at the Release phase.
+- NFR planning items in `test-design` step-05 output checklist conditioned on NFR scope.
+- Engagement models table: TEA Solo row for NFR Evidence Audit updated from No to Optional.
 - GitHub Actions workflow dependencies upgraded to Node 24-compatible major versions:
   - `actions/checkout@v5`
   - `actions/setup-node@v6`

README.md

@@ -3,7 +3,7 @@
 [![Python Version](https://img.shields.io/badge/python-%3E%3D3.10-blue?logo=python&logoColor=white)](https://www.python.org)
 [![uv](https://img.shields.io/badge/uv-package%20manager-blueviolet?logo=uv)](https://docs.astral.sh/uv/)
 
-TEA (Test Engineering Architect) is a standalone BMAD module that delivers risk-based test strategy, test automation guidance, and release gate decisions. It provides a single expert agent (Murat, Master Test Architect and Quality Advisor) and nine workflows spanning Teach Me Testing (TEA Academy), framework setup, test design, ATDD, automation, traceability, NFR assessment, CI guidance, and test review.
+TEA (Test Engineering Architect) is a standalone BMAD module that delivers risk-based test strategy, test automation guidance, and release gate decisions. It provides a single expert agent (Murat, Master Test Architect and Quality Advisor) and nine workflows spanning Teach Me Testing (TEA Academy), test design, framework setup, CI guidance, ATDD, automation, test review, NFR Evidence Audit, and traceability.
 
 Docs: <https://bmad-code-org.github.io/bmad-method-test-architecture-enterprise/>
 
@@ -123,7 +123,7 @@ npx bmad-method install
 1. Install TEA (above)
 2. Load the TEA menu with `$bmad-tea` if you want a conversational entrypoint.
 3. Run one of the core workflows:
-   - `TD` / `/bmad:tea:test-design` / `$bmad-tea-testarch-test-design` — test design and risk assessment
+   - `TD` / `/bmad:tea:test-design` / `$bmad-tea-testarch-test-design` — test design, risk assessment, and NFR planning
    - `AT` / `/bmad:tea:atdd` / `$bmad-tea-testarch-atdd` — failing acceptance tests first (TDD red phase)
    - `TA` / `/bmad:tea:automate` / `$bmad-tea-testarch-automate` — expand automation coverage
 4. Or use in party mode: `/party` to include TEA with other agents
@@ -140,14 +140,14 @@ npx bmad-method install
 | Trigger | Slash Command                | Codex Skill                      | Purpose                                                   |
 | ------- | ---------------------------- | -------------------------------- | --------------------------------------------------------- |
 | TMT     | `/bmad:tea:teach-me-testing` | `$bmad-tea-teach-me-testing`     | Teach Me Testing (TEA Academy)                            |
+| TD      | `/bmad:tea:test-design`      | `$bmad-tea-testarch-test-design` | System-level or epic-level test design and NFR planning   |
 | TF      | `/bmad:tea:framework`        | `$bmad-tea-testarch-framework`   | Scaffold test framework (frontend, backend, or fullstack) |
 | CI      | `/bmad:tea:ci`               | `$bmad-tea-testarch-ci`          | Set up CI/CD quality pipeline (multi-platform)            |
-| TD      | `/bmad:tea:test-design`      | `$bmad-tea-testarch-test-design` | System-level or epic-level test design                    |
 | AT      | `/bmad:tea:atdd`             | `$bmad-tea-testarch-atdd`        | Generate failing acceptance tests + checklist             |
 | TA      | `/bmad:tea:automate`         | `$bmad-tea-testarch-automate`    | Expand test automation coverage                           |
 | RV      | `/bmad:tea:test-review`      | `$bmad-tea-testarch-test-review` | Review test quality and score                             |
+| NR      | `/bmad:tea:nfr-assess`       | `$bmad-tea-testarch-nfr`         | Audit implemented NFR evidence                            |
 | TR      | `/bmad:tea:trace`            | `$bmad-tea-testarch-trace`       | Trace requirements to tests + gate decision               |
-| NR      | `/bmad:tea:nfr-assess`       | `$bmad-tea-testarch-nfr`         | Assess non-functional requirements                        |
 
 ## Configuration
 

docs/explanation/engagement-models.md

@@ -205,12 +205,11 @@ Steps:
 **Phase 2: Planning**
 
 - PM creates PRD with NFRs
-- (Optional) TEA runs `nfr-assess` (Enterprise only)
 
 **Phase 3: Solutioning**
 
 - Architect creates architecture
-- TEA runs `test-design` (system-level) → testability review
+- TEA runs `test-design` (system-level) → testability review and NFR evidence plan
 - TEA runs `framework` → test infrastructure
 - TEA runs `ci` → CI/CD pipeline
 - Architect runs `implementation-readiness` (fed by test design)
@@ -229,7 +228,7 @@ Steps:
 **Release Gate:**
 
 - (Optional) TEA runs `test-review` → final audit
-- (Optional) TEA runs `nfr-assess` → validate NFRs
+- (Optional) TEA runs `nfr-assess` → audit NFR evidence
 - TEA runs `trace` Phase 2 → gate decision (PASS/CONCERNS/FAIL/WAIVED)
 
 **What You Get:**
@@ -396,7 +395,7 @@ flowchart TD
 | -------------------------- | --------------------------- | ----------------------------- |
 | **None**                   | Any model                   | Choose based on project needs |
 | **Light** (internal audit) | TEA Solo or Integrated      | Gate decisions helpful        |
-| **Heavy** (SOC 2, HIPAA)   | TEA Integrated (Enterprise) | NFR assessment mandatory      |
+| **Heavy** (SOC 2, HIPAA)   | TEA Integrated (Enterprise) | NFR evidence audit mandatory  |
 
 ## Switching Between Models
 
@@ -444,17 +443,17 @@ Result: TEA where it adds value, skip where it doesn't
 
 ## Comparison Table
 
-| Aspect                | No TEA  | TEA Lite  | TEA Solo   | Integrated (Green) | Integrated (Brown) |
-| --------------------- | ------- | --------- | ---------- | ------------------ | ------------------ |
-| **BMad Required**     | No      | No        | No         | Yes                | Yes                |
-| **Learning Curve**    | None    | Low       | Medium     | High               | High               |
-| **Setup Time**        | 0       | 30 min    | 2 hours    | 1 day              | 2 days             |
-| **Workflows Used**    | 0       | 2-3       | 4-6        | 8                  | 8                  |
-| **Test Planning**     | Manual  | Optional  | Yes        | Systematic         | + Regression focus |
-| **Quality Gates**     | No      | No        | Optional   | Yes                | Yes + baseline     |
-| **NFR Assessment**    | No      | No        | No         | Optional           | Recommended        |
-| **Coverage Tracking** | Manual  | No        | Optional   | Yes                | Yes + trending     |
-| **Best For**          | Experts | Beginners | Standalone | New projects       | Legacy code        |
+| Aspect                 | No TEA  | TEA Lite  | TEA Solo   | Integrated (Green) | Integrated (Brown) |
+| ---------------------- | ------- | --------- | ---------- | ------------------ | ------------------ |
+| **BMad Required**      | No      | No        | No         | Yes                | Yes                |
+| **Learning Curve**     | None    | Low       | Medium     | High               | High               |
+| **Setup Time**         | 0       | 30 min    | 2 hours    | 1 day              | 2 days             |
+| **Workflows Used**     | 0       | 2-3       | 4-6        | 8                  | 8                  |
+| **Test Planning**      | Manual  | Optional  | Yes        | Systematic         | + Regression focus |
+| **Quality Gates**      | No      | No        | Optional   | Yes                | Yes + baseline     |
+| **NFR Evidence Audit** | No      | No        | Optional   | Optional           | Recommended        |
+| **Coverage Tracking**  | Manual  | No        | Optional   | Yes                | Yes + trending     |
+| **Best For**           | Experts | Beginners | Standalone | New projects       | Legacy code        |
 
 ## Real-World Examples
 
@@ -496,7 +495,7 @@ Decision: Full BMad Method + TEA Integrated
 Result:
 - Full lifecycle integration
 - Quality gates before releases
-- NFR assessment for enterprise customers
+- NFR evidence audit for enterprise customers
 ```
 
 ### Example 2: Enterprise (TEA Integrated - Brownfield)

docs/explanation/risk-based-testing.md

@@ -611,7 +611,7 @@ flowchart TD
 
 - [How to Run Test Design](/docs/how-to/workflows/run-test-design.md) - Apply risk scoring
 - [How to Run Trace](/docs/how-to/workflows/run-trace.md) - Gate decisions based on risk
-- [How to Run NFR Assessment](/docs/how-to/workflows/run-nfr-assess.md) - NFR risk assessment
+- [How to Run NFR Evidence Audit](/docs/how-to/workflows/run-nfr-assess.md) - NFR evidence status for gate decisions
 
 **Use-Case Guides:**