Skip to content

fix: release node warnings#101

Merged
muratkeremozcan merged 3 commits into
mainfrom
fix/release-node-warnings
May 8, 2026
Merged

fix: release node warnings#101
muratkeremozcan merged 3 commits into
mainfrom
fix/release-node-warnings

Conversation

@muratkeremozcan

Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai

coderabbitai Bot commented May 8, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR modernizes repository governance and CI/CD practices. It introduces formal repository standards, updates GitHub Actions to Node 24-compatible versions with .nvmrc-based Node selection, enhances release publishing with a fallback to the [Unreleased] changelog section, documents a new release (1.16.0), and establishes changelog discipline conventions.

Changes

Release Process Hygiene and Workflow Modernization

Layer / File(s) Summary
Repository Guidelines and Standards
AGENTS.md
Defines repository structure, release-metadata synchronization across package.json, package-lock.json, and .claude-plugin/marketplace.json, standard commands (test, format, lint, docs, sync), changelog discipline with Keep a Changelog and [Unreleased] sections, and PR notes expectations.
Changelog Updates and Release Documentation
CHANGELOG.md
Adds [Unreleased] section documenting GitHub Actions upgrades and release-publishing changes. Introduces [1.16.0] release documenting plugin/cowork support, documentation examples, guidance clarifications, and catalog fixes. Separates historical notes with [Historical Unreleased Notes] header.
Workflow Action Version Upgrades
.github/workflows/docs.yaml, .github/workflows/quality.yaml, .github/workflows/publish.yaml
Upgrades actions/checkout from v4 to v5 across all workflows and actions/setup-node from v4 to v6. Switches Node version selection from hard-coded 20 to reading from .nvmrc. Updates actions/create-github-app-token from v2 to v3 in publish workflow.
Release Publishing Fallback Logic
.github/workflows/publish.yaml
Adds helper to detect non-whitespace in release notes. If version-specific notes are missing, attempts to source notes from [Unreleased] section of CHANGELOG.md with a notice. Falls back to auto-generated notes only if both version and [Unreleased] sections are empty.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix: release node warnings' is vague and does not clearly match the actual changes made, which primarily involve upgrading GitHub Actions versions and adding workflow improvements. Consider a more descriptive title that reflects the main changes, such as 'chore: upgrade GitHub Actions and add workflow improvements' or 'chore: update Actions versions and improve release workflow'.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether it relates to the changeset. Add a description explaining the purpose of upgrading GitHub Actions versions, adding the AGENTS.md guidelines, and the changelog updates.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-node-warnings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@augmentcode

augmentcode Bot commented May 8, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR updates GitHub Actions workflows to reduce Node runtime deprecation warnings and improves release note generation.

Changes:

  • Bump actions/checkout to v5 and actions/setup-node to v6 across docs/quality/publish workflows.
  • Use .nvmrc as the Node version source for workflow Node setup (including docs).
  • In publish, fall back to the changelog’s [Unreleased] section when a version-specific section is missing.
  • Add AGENTS.md and update CHANGELOG.md to document the workflow/release behavior changes.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread .github/workflows/publish.yaml Outdated
}
found { print }
' CHANGELOG.md)
if [ -z "$BODY" ]; then

@augmentcode augmentcode Bot May 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/publish.yaml:161: -z "$BODY" only detects an empty string, so a changelog section that contains only blank lines will be treated as “present” and can produce a GitHub Release with effectively empty notes (and skip the intended fallback behavior). Consider treating whitespace-only output as missing as well.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/publish.yaml (1)

153-177: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Separator-only fallback can be misdetected as valid release notes.

If extracted notes contain only a markdown rule (---) plus blank lines, has_release_notes still returns true, and the release body becomes effectively empty/noisy. Consider ignoring separator-only lines when determining note presence.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/publish.yaml around lines 153 - 177, The has_release_notes
check currently treats a BODY containing only markdown rules like '---' and
blank lines as valid; update the logic used to validate BODY (the
has_release_notes function and/or the point where BODY is evaluated after the
awk extracts) to ignore lines that are empty or consist solely of markdown
separators (e.g. lines matching ^[[:space:]]*[-]{3,}[[:space:]]*$) before
deciding presence of notes, so only BODY with at least one non-blank,
non-separator line returns true; keep the existing awk extraction into BODY but
apply this filtering test against BODY before the if ! has_release_notes "$BODY"
checks.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In @.github/workflows/publish.yaml:
- Around line 153-177: The has_release_notes check currently treats a BODY
containing only markdown rules like '---' and blank lines as valid; update the
logic used to validate BODY (the has_release_notes function and/or the point
where BODY is evaluated after the awk extracts) to ignore lines that are empty
or consist solely of markdown separators (e.g. lines matching
^[[:space:]]*[-]{3,}[[:space:]]*$) before deciding presence of notes, so only
BODY with at least one non-blank, non-separator line returns true; keep the
existing awk extraction into BODY but apply this filtering test against BODY
before the if ! has_release_notes "$BODY" checks.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d08960a9-6f37-43c2-9a18-b2d2f254dcd1

📥 Commits

Reviewing files that changed from the base of the PR and between cd54279 and cacce56.

📒 Files selected for processing (5)
  • .github/workflows/docs.yaml
  • .github/workflows/publish.yaml
  • .github/workflows/quality.yaml
  • AGENTS.md
  • CHANGELOG.md

@muratkeremozcan muratkeremozcan merged commit e9a791f into main May 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant