Make TEA config defaults non-interactive#108
Conversation
🤖 Augment PR SummarySummary: This PR makes TEA (Test Engineering Architect) installation/configuration non-interactive by turning TEA module config prompts into fixed defaults. Changes:
Technical Notes: Defaults are now expressed in both 🤖 Was this summary useful? React with 👍 or 👎 |
|
|
||
| assert(customizeContent.includes('[agent]'), 'customize.toml has [agent] section'); | ||
| assert(customizeContent.includes('[config]'), 'customize.toml has [config] defaults section'); | ||
| assert(/^\s*tea_use_playwright_utils\s*=\s*true/m.test(customizeContent), 'customize.toml defaults Playwright Utils on'); |
There was a problem hiding this comment.
test/test-installation-components.js:162: These regex assertions only verify the keys appear somewhere in customize.toml, so the test could still pass even if the defaults are accidentally moved outside the [config] block. That could mask a mis-scoped default that future customization tooling would ignore.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
📝 WalkthroughWalkthroughThis PR shifts TEA from interactive installer questions to non-interactive defaults. The ChangesTEA Non-Interactive Defaults Configuration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/reference/configuration.md (1)
1080-1086: ⚡ Quick winConsider clarifying installation instructions wording.
Lines 1080-1084 use "when you want" phrasing that might confuse users, since these utilities are already enabled by default. The current wording suggests they're opt-in, when they're actually opt-out.
Consider rewording to reflect the default-enabled state more clearly:
5. Install playwright-utils to use the enabled-by-default utility fixtures: npm install -D `@seontechnologies/playwright-utils` 6. Install pactjs-utils to use the enabled-by-default contract-testing patterns: npm install -D `@seontechnologies/pactjs-utils` `@pact-foundation/pact` 7. Install SmartBear MCP if your service uses PactFlow/Pact Broker: npm install -g `@smartbear/mcp`🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/reference/configuration.md` around lines 1080 - 1086, Update the phrasing in the installation steps for "playwright-utils", "pactjs-utils" and SmartBear MCP to reflect that the utility fixtures and contract-testing patterns are enabled by default (i.e., opt-out) rather than implying they are opt-in; replace "when you want" wording with language like "to use the enabled-by-default utility fixtures" for playwright-utils, "to use the enabled-by-default contract-testing patterns" for pactjs-utils, and change the Pact MCP line to "Install SmartBear MCP if your service uses PactFlow/Pact Broker" so the intent is clear for readers.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/reference/configuration.md`:
- Around line 1080-1086: Update the phrasing in the installation steps for
"playwright-utils", "pactjs-utils" and SmartBear MCP to reflect that the utility
fixtures and contract-testing patterns are enabled by default (i.e., opt-out)
rather than implying they are opt-in; replace "when you want" wording with
language like "to use the enabled-by-default utility fixtures" for
playwright-utils, "to use the enabled-by-default contract-testing patterns" for
pactjs-utils, and change the Pact MCP line to "Install SmartBear MCP if your
service uses PactFlow/Pact Broker" so the intent is clear for readers.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c7a397ad-b6d5-4ca2-8ae4-3de9bef7fb9d
📒 Files selected for processing (10)
CHANGELOG.mdREADME.mddocs/explanation/tea-overview.mddocs/how-to/customization/integrate-playwright-utils.mddocs/how-to/workflows/setup-test-framework.mddocs/reference/configuration.mddocs/reference/troubleshooting.mdsrc/agents/bmad-tea/customize.tomlsrc/module.yamltest/test-installation-components.js
Summary
Notes