Skip to content

Commit 16ad2f9

Browse files
author
Vincent M.
committed
fix: address remaining PR #3 review feedback
Resolve critical, high, medium, and low priority findings from PR review. Critical: fix .vscodeignore packaging gaps, remove dual lock file, move bundled deps to devDependencies, fix double build in release. High: add path traversal validation in editor panel, cap unbounded error arrays in Zustand stores. Medium: fix tr role="button" accessibility violation, remove dead @shared/* path alias, fix double build in .releaserc.json. Low: use crypto.randomBytes for CSP nonce, extract duplicated toKebabCase to shared utility, align USER_STORY_REGEX across parsers, replace hardcoded header prefix length, add debug logging to silent catch blocks.
1 parent 7fa6620 commit 16ad2f9

16 files changed

Lines changed: 87 additions & 16377 deletions

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
# Dependencies
44
node_modules
5+
package-lock.json
56
.pnp
67
.pnp.js
78

.releaserc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
[
1919
"@semantic-release/exec",
2020
{
21-
"prepareCmd": "pnpm build && pnpm vscode:package"
21+
"prepareCmd": "pnpm vscode:package"
2222
}
2323
],
2424
[

.vscodeignore

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# Ensure bundled output is always included
2+
!out/**
3+
14
# Source and config (only bundled output is needed)
25
src/**
36
**/*.test.ts
@@ -15,11 +18,14 @@ node_modules/**
1518
.github/**
1619
.releaserc.json
1720
vite.config.ts
21+
vitest.config.ts
1822
tsconfig*.json
1923
vitest.setup.ts
2024
eslint.config.*
2125
.prettierrc*
2226
.gitignore
27+
pnpm-lock.yaml
28+
.vscode-test.mjs
2329
coverage/**
2430

2531
# BMAD project artifacts (not part of the extension)

0 commit comments

Comments
 (0)