Skip to content

Commit 258b620

Browse files
author
Vincent M.
committed
chore: small tech improvement fixes
1 parent ef68402 commit 258b620

6 files changed

Lines changed: 20 additions & 16 deletions

File tree

README.md

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -132,25 +132,18 @@ pnpm typecheck # typecheck both extension and webview
132132

133133
## Release Process
134134

135-
Versioning and releases are fully automated via [semantic-release](https://github.com/semantic-release/semantic-release) and a GitHub Actions workflow.
135+
Versioning and releases are fully automated via [semantic-release](https://github.com/semantic-release/semantic-release). CI/CD workflows are not yet configured — see below for how to run releases locally.
136136

137137
### How it works
138138

139-
1. **Push to `main`** triggers the release workflow (`.github/workflows/release.yml`)
140-
2. **Commit analysis**`@semantic-release/commit-analyzer` determines the next version from [Conventional Commits](https://www.conventionalcommits.org/):
139+
1. **Commit analysis**`@semantic-release/commit-analyzer` determines the next version from [Conventional Commits](https://www.conventionalcommits.org/):
141140
- `fix:` → patch bump (1.2.x)
142141
- `feat:` → minor bump (1.x.0)
143142
- `BREAKING CHANGE:` / `feat!:` → major bump (x.0.0)
144-
3. **Changelog**`CHANGELOG.md` is updated automatically
145-
4. **Build & package** — the extension is built and packaged as a `.vsix`
146-
5. **Git commit**`package.json` and `CHANGELOG.md` are committed with `chore(release): <version> [skip ci]`
147-
6. **GitHub release** — a release is created with the `.vsix` attached as a downloadable asset
148-
149-
### CI pipeline
150-
151-
Pull requests to `main` run the CI workflow (`.github/workflows/ci.yml`):
152-
153-
- Lint → Typecheck → Test → Build
143+
2. **Changelog**`CHANGELOG.md` is updated automatically
144+
3. **Build & package** — the extension is built and packaged as a `.vsix`
145+
4. **Git commit**`package.json` and `CHANGELOG.md` are committed with `chore(release): <version> [skip ci]`
146+
5. **GitHub release** — a release is created with the `.vsix` attached as a downloadable asset
154147

155148
### Local dry run
156149

eslint.config.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,6 @@ export default defineConfig(
191191
// IGNORES
192192
// ============================================================================
193193
{
194-
ignores: ['out/', 'node_modules/', '.vscode-test/', '*.js', '*.mjs'],
194+
ignores: ['out/', 'node_modules/', '.vscode-test/', 'coverage/', '*.js', '*.mjs'],
195195
}
196196
);

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"vscode:prepublish": "pnpm build",
2424
"vscode:package": "npx @vscode/vsce package --no-dependencies -o out/",
2525
"build": "pnpm build:extension && pnpm build:webview",
26-
"build:extension": "esbuild src/extension/extension.ts --bundle --outfile=out/extension/extension.js --external:vscode --format=cjs --platform=node --sourcemap",
26+
"build:extension": "esbuild src/extension/extension.ts --bundle --outfile=out/extension/extension.js --external:vscode --format=cjs --platform=node --sourcemap --minify",
2727
"build:webview": "vite build",
2828
"watch": "pnpm run --parallel '/watch:.*/'",
2929
"watch:extension": "esbuild src/extension/extension.ts --bundle --outfile=out/extension/extension.js --external:vscode --format=cjs --platform=node --sourcemap --watch",

src/webviews/dashboard/utils/build-command-with-story.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ const makeStory = (overrides: Partial<Story> = {}): Story => ({
1010
userStory: '',
1111
acceptanceCriteria: [],
1212
tasks: [],
13+
totalTasks: 0,
14+
completedTasks: 0,
15+
totalSubtasks: 0,
16+
completedSubtasks: 0,
1317
filePath: '_bmad-output/epics/epic-1/1-2-test-story.md',
1418
status: 'in-progress',
1519
...overrides,

tsconfig.extension.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@
1212
"forceConsistentCasingInFileNames": true,
1313
"resolveJsonModule": true,
1414
"declaration": true,
15-
"sourceMap": true
15+
"sourceMap": true,
16+
"noUnusedLocals": true,
17+
"noUnusedParameters": true
1618
},
1719
"include": [
1820
"src/extension/**/*",

vitest.config.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,11 @@ export default defineConfig({
2929
setupFiles: ['./vitest.setup.ts'],
3030
coverage: {
3131
provider: 'v8',
32+
thresholds: {
33+
lines: 70,
34+
branches: 65,
35+
functions: 70,
36+
},
3237
},
3338
},
3439
});

0 commit comments

Comments
 (0)