Skip to content

fix(skills): remove Agent Space references + sync WDS May improvements#34

Merged
MartenAngner merged 1 commit into
mainfrom
fix/sync-wds-may-improvements
May 19, 2026
Merged

fix(skills): remove Agent Space references + sync WDS May improvements#34
MartenAngner merged 1 commit into
mainfrom
fix/sync-wds-may-improvements

Conversation

@MartenAngner

Copy link
Copy Markdown
Collaborator

Summary

  • Bug fix: Remove hardcoded Supabase/Agent Space URLs from start.md, wrap.md, and handoff.md — these should never have been in a public BMad module. Handoffs now write to progress/[target_agent].md (file-based). Agent picks up via /[agent] progress/[agent].md.
  • New: src/data/wds-glossary.md — locked terminology for all agents (phases, artifacts, model selection, patterns)
  • New: src/data/agent-contracts.md — domain boundaries, prerequisites, handoff rules, out-of-scope per agent
  • New: src/data/shared-activation.md — common startup steps (state, scan, select, brownfield-detect) referenced by all agents
  • Fix: src/tools/memory/SKILL.md — rename to wds-memory, remove WDS-E/external storage references

Test plan

  • Install module fresh: npx bmad-method install
  • Verify /wrap mimir writes to progress/mimir.md (no external call)
  • Verify /handoff freya writes to progress/freya.md
  • Verify /start reads progress/[agent].md and shows resume prompt
  • Confirm no Supabase URLs appear in installed skill files

🤖 Generated with Claude Code

- Remove hardcoded Supabase URLs from start.md, wrap.md, handoff.md
  Handoffs now write to progress/[target_agent].md (file-based, no
  external dependency). Resumption via /[agent] progress/[agent].md.
- Add src/data/wds-glossary.md — locked terminology for all agents
- Add src/data/agent-contracts.md — domain boundaries, handoff rules,
  prerequisites, quality rules, out-of-scope per agent
- Add src/data/shared-activation.md — common startup steps referenced
  by all agents instead of repeated inline
- Fix src/tools/memory/SKILL.md: rename to wds-memory, remove WDS-E
  and external storage references

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@MartenAngner has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 26 minutes and 27 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 17bc41b9-e16f-4be4-b2bb-1c4116114a54

📥 Commits

Reviewing files that changed from the base of the PR and between 302a6d4 and 602fc7a.

📒 Files selected for processing (7)
  • src/data/agent-contracts.md
  • src/data/shared-activation.md
  • src/data/wds-glossary.md
  • src/skills/handoff.md
  • src/skills/start.md
  • src/skills/wrap.md
  • src/tools/memory/SKILL.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sync-wds-may-improvements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MartenAngner MartenAngner merged commit 8e5bc61 into main May 19, 2026
20 checks passed
@augmentcode

augmentcode Bot commented May 19, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR removes Agent Space/Supabase dependencies from the WDS skills and aligns the workflow with a local, file-based session state and handoff mechanism.

Changes:

  • Removed hardcoded Agent Space (Supabase) curl calls and credentials from /start, /wrap, and /handoff skills.
  • Updated handoff behavior so cross-agent handoffs are written to progress/[target_agent].md (file-based) and picked up via the target agent.
  • Added src/data/wds-glossary.md to standardize WDS terminology (phases, artifacts, folder structure, patterns, model selection).
  • Added src/data/agent-contracts.md defining domain boundaries, prerequisites, handoff triggers, and explicit out-of-scope rules per agent.
  • Added src/data/shared-activation.md for shared startup steps (state/scan/select/brownfield detect) referenced by agents.
  • Renamed the memory tool from memory to wds-memory and removed references to external storage backends.

Technical Notes: The wrap flow still updates progress/project-index.md, but no longer attempts to publish semantic indexing to Agent Space; all persistence is now local to the project�s progress/ folder.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

## Step: state

Check for session state via the memory tool.
Read `~/.claude/wds/src/tools/memory/SKILL.md` and follow the `load` operation for the current agent_id.

@augmentcode augmentcode Bot May 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In src/data/shared-activation.md line 11, the docs hardcode an absolute ~/.claude/... path to the memory SKILL, which is likely to break on Windows or any install that places the module elsewhere. Can we confirm this path is guaranteed in all supported setups (including NPX/manual installs)?

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread src/skills/wrap.md

**Step A — Save handoff via memory tool:**
Read `~/.claude/wds/src/tools/memory/SKILL.md` and follow the `save` operation:
- agent_id: [target_agent]

@augmentcode augmentcode Bot May 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In src/skills/wrap.md line 161, the handoff save uses agent_id: [target_agent], which writes directly to progress/[target_agent].md and will overwrite any existing state file for that agent in the project. If concurrent/queued handoffs or an in-progress target-agent session are possible, this could cause state loss—worth confirming this overwrite behavior is intentional.

Severity: medium

Other Locations
  • src/skills/handoff.md:60

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread src/tools/memory/SKILL.md
- `progress/` should be in `.gitignore`. It is machine-local session context, not project content.
- Both save and load are synchronous file operations — no tokens, no async, no IDs.
- WDS-E replaces this file with `tools/memory/SKILL.md` that routes to Agent Space instead. The interface (save/load inputs and return values) is identical — only the storage destination changes.
- This is the canonical storage backend. State is local to the machine and project — not synced, not shared.

@augmentcode augmentcode Bot May 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In src/tools/memory/SKILL.md line 51, the Notes describe state as machine-local and not shared, but earlier in the file it says the progress/ folder is “not per-machine.” This contradiction could confuse agents/users about whether session state should be expected to survive across machines.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread src/skills/wrap.md
```
Post silently — do not wait for responses or report individual results. If Agent Space is unreachable, skip silently and continue.

**Step D — Confirm:**

@augmentcode augmentcode Bot May 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In src/skills/wrap.md line 143, the subagent prompt jumps from “Step B” to “Step D” after the Agent Space section was removed. This can be confusing when following the instructions verbatim, especially since the prompt emphasizes exact execution.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant