Skip to content

refactor: replace bmad-init with direct config loading #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmadcode merged 1 commit into from
Mar 29, 2026
Merged

refactor: replace bmad-init with direct config loading #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/skills/bmad-cis-agent-brainstorming-coach/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ When you are in this persona and the user calls a skill, this persona must carry

## On Activation

1. **Load config via bmad-init skill** — Store all returned vars for use:
- Use `{user_name}` from config for greeting
- Use `{communication_language}` from config for all communications
- Store any other config variables as `{var-name}` and use appropriately
1. Load config from `{project-root}/_bmad/cis/config.yaml` and resolve:
- Use `{user_name}` for greeting
- Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents

Copy link
Copy Markdown

@augmentcode augmentcode Bot Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now instructs agents to use {document_output_language}, but this repo’s CIS configuration reference/defaults only define output_folder, user_name, and communication_language; if the key isn’t present in a user’s _bmad/cis/config.yaml, the placeholder could remain unresolved or lead to inconsistent document language. Consider confirming this config key is part of the supported contract (and documented) wherever CIS config defaults are defined.

Severity: medium

Other Locations
  • src/skills/bmad-cis-agent-creative-problem-solver/SKILL.md:42
  • src/skills/bmad-cis-agent-design-thinking-coach/SKILL.md:43
  • src/skills/bmad-cis-agent-innovation-strategist/SKILL.md:42
  • src/skills/bmad-cis-agent-presentation-master/SKILL.md:53
  • src/skills/bmad-cis-agent-storyteller/SKILL.md:47

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

2. **Continue with steps below:**
- **Load project context** — Search for `**/project-context.md`. If found, load as foundational reference for project standards and conventions. If not found, continue without it.
Expand Down
8 changes: 4 additions & 4 deletions src/skills/bmad-cis-agent-creative-problem-solver/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ When you are in this persona and the user calls a skill, this persona must carry

## On Activation

1. **Load config via bmad-init skill** — Store all returned vars for use:
- Use `{user_name}` from config for greeting
- Use `{communication_language}` from config for all communications
- Store any other config variables as `{var-name}` and use appropriately
1. Load config from `{project-root}/_bmad/cis/config.yaml` and resolve:
- Use `{user_name}` for greeting
- Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents

2. **Continue with steps below:**
- **Load project context** — Search for `**/project-context.md`. If found, load as foundational reference for project standards and conventions. If not found, continue without it.
Expand Down
8 changes: 4 additions & 4 deletions src/skills/bmad-cis-agent-design-thinking-coach/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ When you are in this persona and the user calls a skill, this persona must carry

## On Activation

1. **Load config via bmad-init skill** — Store all returned vars for use:
- Use `{user_name}` from config for greeting
- Use `{communication_language}` from config for all communications
- Store any other config variables as `{var-name}` and use appropriately
1. Load config from `{project-root}/_bmad/cis/config.yaml` and resolve:
- Use `{user_name}` for greeting
- Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents
Comment on lines +39 to +42
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Define fallback/error handling for config load failures.

This activation flow can hard-fail if config.yaml is missing, malformed, or missing keys. Add explicit fallback/default behavior so agent activation remains predictable.

Suggested doc patch 
 1. Load config from `{project-root}/_bmad/cis/config.yaml` and resolve:
    - Use `{user_name}` for greeting
    - Use `{communication_language}` for all communications
    - Use `{document_output_language}` for output documents
+   - If file is missing/invalid, continue with safe defaults:
+     - `{user_name}` = `there`
+     - `{communication_language}` = `English`
+     - `{document_output_language}` = `{communication_language}`
+   - If any key is missing, apply the same defaults and continue.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
1. Load config from `{project-root}/_bmad/cis/config.yaml` and resolve:
- Use `{user_name}` for greeting
- Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents
1. Load config from `{project-root}/_bmad/cis/config.yaml` and resolve:
- Use `{user_name}` for greeting
- Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents
- If file is missing/invalid, continue with safe defaults:
- `{user_name}` = `there`
- `{communication_language}` = `English`
- `{document_output_language}` = `{communication_language}`
- If any key is missing, apply the same defaults and continue.
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@src/skills/bmad-cis-agent-design-thinking-coach/SKILL.md` around lines 39 -
42, The activation flow currently trusts loading
`{project-root}/_bmad/cis/config.yaml` and can hard-fail; update the
config-loading logic to catch file-not-found and YAML parse errors, validate
presence of `{user_name}`, `{communication_language}`, and
`{document_output_language}` keys, and apply safe defaults (e.g.,
user_name="User", communication_language="en", document_output_language="en")
when missing or invalid; ensure errors are logged (warning for missing keys,
error for parse failures) but do not throw, and keep the agent activation
predictable by proceeding with the defaulted values and replacing placeholders
accordingly.


2. **Continue with steps below:**
- **Load project context** — Search for `**/project-context.md`. If found, load as foundational reference for project standards and conventions. If not found, continue without it.
Expand Down
8 changes: 4 additions & 4 deletions src/skills/bmad-cis-agent-innovation-strategist/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ When you are in this persona and the user calls a skill, this persona must carry

## On Activation

1. **Load config via bmad-init skill** — Store all returned vars for use:
- Use `{user_name}` from config for greeting
- Use `{communication_language}` from config for all communications
- Store any other config variables as `{var-name}` and use appropriately
1. Load config from `{project-root}/_bmad/cis/config.yaml` and resolve:
- Use `{user_name}` for greeting
- Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents

2. **Continue with steps below:**
- **Load project context** — Search for `**/project-context.md`. If found, load as foundational reference for project standards and conventions. If not found, continue without it.
Expand Down
8 changes: 4 additions & 4 deletions src/skills/bmad-cis-agent-presentation-master/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ When you are in this persona and the user calls a skill, this persona must carry

## On Activation

1. **Load config via bmad-init skill** — Store all returned vars for use:
- Use `{user_name}` from config for greeting
- Use `{communication_language}` from config for all communications
- Store any other config variables as `{var-name}` and use appropriately
1. Load config from `{project-root}/_bmad/cis/config.yaml` and resolve:
- Use `{user_name}` for greeting
- Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents

2. **Continue with steps below:**
- **Load project context** — Search for `**/project-context.md`. If found, load as foundational reference for project standards and conventions. If not found, continue without it.
Expand Down
8 changes: 4 additions & 4 deletions src/skills/bmad-cis-agent-storyteller/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ When you are in this persona and the user calls a skill, this persona must carry

## On Activation

1. **Load config via bmad-init skill** — Store all returned vars for use:
- Use `{user_name}` from config for greeting
- Use `{communication_language}` from config for all communications
- Store any other config variables as `{var-name}` and use appropriately
1. Load config from `{project-root}/_bmad/cis/config.yaml` and resolve:
- Use `{user_name}` for greeting
- Use `{communication_language}` for all communications
- Use `{document_output_language}` for output documents

2. **Continue with steps below:**
- **Load project context** — Search for `**/project-context.md`. If found, load as foundational reference for project standards and conventions. If not found, continue without it.
Expand Down
1 change: 0 additions & 1 deletion src/skills/bmad-cis-design-thinking/workflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
name: bmad-cis-design-thinking
description: 'Guide human-centered design processes using empathy-driven methodologies. Use when the user says "lets run design thinking" or "I want to apply design thinking"'
standalone: true
main_config: '{project-root}/_bmad/cis/config.yaml'
---

Expand Down
1 change: 0 additions & 1 deletion src/skills/bmad-cis-innovation-strategy/workflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
name: bmad-cis-innovation-strategy
description: 'Identify disruption opportunities and architect business model innovation. Use when the user says "lets create an innovation strategy" or "I want to find disruption opportunities"'
standalone: true
main_config: '{project-root}/_bmad/cis/config.yaml'
---

Expand Down
1 change: 0 additions & 1 deletion src/skills/bmad-cis-problem-solving/workflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
name: bmad-cis-problem-solving
description: 'Apply systematic problem-solving methodologies to complex challenges. Use when the user says "guide me through structured problem solving" or "I want to crack this challenge with guided problem solving techniques"'
standalone: true
main_config: '{project-root}/_bmad/cis/config.yaml'
---

Expand Down
1 change: 0 additions & 1 deletion src/skills/bmad-cis-storytelling/workflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
name: bmad-cis-storytelling
description: 'Craft compelling narratives using story frameworks. Use when the user says "help me with storytelling" or "I want to create a narrative through storytelling"'
standalone: true
main_config: '{project-root}/_bmad/cis/config.yaml'
---

Expand Down
Loading