-
-
Notifications
You must be signed in to change notification settings - Fork 11
feat(workflows): adopt customize.toml pattern for workflow skills #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # DO NOT EDIT -- overwritten on every update. | ||
| # | ||
| # Workflow customization surface for bmad-cis-design-thinking. Mirrors the | ||
| # agent customization shape under the [workflow] namespace. | ||
|
|
||
| [workflow] | ||
|
|
||
| # --- Configurable below. Overrides merge per BMad structural rules: --- | ||
| # scalars: override wins • arrays (persistent_facts, activation_steps_*): append | ||
| # arrays-of-tables with `code`/`id`: replace matching items, append new ones. | ||
|
|
||
| # Steps to run before the standard activation (config load, greet). | ||
| # Overrides append. Use for pre-flight loads, compliance checks, etc. | ||
|
|
||
| activation_steps_prepend = [] | ||
|
|
||
| # Steps to run after greet but before the workflow begins. | ||
| # Overrides append. Use for context-heavy setup that should happen | ||
| # once the user has been acknowledged. | ||
|
|
||
| activation_steps_append = [] | ||
|
|
||
| # Persistent facts the workflow keeps in mind for the whole run | ||
| # (standards, compliance constraints, stylistic guardrails). | ||
| # Distinct from the runtime memory sidecar — these are static context | ||
| # loaded on activation. Overrides append. | ||
| # | ||
| # Each entry is either: | ||
| # - a literal sentence, e.g. "Empathy interviews must include at least 5 real users before ideation." | ||
| # - a file reference prefixed with `file:`, e.g. "file:{project-root}/docs/standards.md" | ||
| # (glob patterns are supported; the file's contents are loaded and treated as facts). | ||
|
|
||
| persistent_facts = [ | ||
| "file:{project-root}/**/project-context.md", | ||
| ] | ||
|
|
||
| # Scalar: executed when the workflow reaches Step 7 (Plan next iteration), | ||
| # after refinements, action items, and success metrics are captured. Override wins. | ||
| # Leave empty for no custom post-completion behavior. | ||
|
|
||
| on_complete = "" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/skills/bmad-cis-design-thinking/SKILL.md:271 — These workflows invoke
resolve_customization.pywith--key workflow.on_complete; if the resolver only supports top-level blocks (as implied by existing--key agent/--key workflowusage), this may fail at runtime and preventon_completefrom running.Severity: medium
Other Locations
src/skills/bmad-cis-innovation-strategy/SKILL.md:344src/skills/bmad-cis-problem-solving/SKILL.md:304src/skills/bmad-cis-problem-solving/SKILL.md:322src/skills/bmad-cis-storytelling/SKILL.md:350🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolve_customization.pyalready supports dotted keys —extract_keyat line 169–177 splits on.and walks the tree, and the script docstring lists--key agent.menuas a supported example. So--key workflow.on_completeresolves to theon_completescalar inside the merged[workflow]table exactly as intended.