feat(cis): convert innovation strategy to a native skill#6
Merged
bmadcode merged 1 commit intobmad-code-org:mainfrom Mar 14, 2026
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (8)
WalkthroughThis PR refactors the innovation strategy workflow from a YAML-based configuration to a native-skill layout. The workflow is relocated from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
AGENTS.md (1)
36-47:⚠️ Potential issue | 🟡 MinorKeep the workflow tree in sync with the actual source layout.
This diagram now skips
src/workflows/brainstorming/, even though the repo still documents Brainstorming as a first-class workflow insrc/workflows/README.md. New contributors will get the wrong directory map from this block.📝 Suggested doc fix
src/ ├── agents/ # Agent definitions (*.agent.yaml) │ └── storyteller/ # Sidecar agents with persistent memory ├── workflows/ # Structured methodologies +│ ├── brainstorming/ │ ├── design-thinking/ │ ├── bmad-cis-innovation-strategy/ │ ├── problem-solving/ │ └── storytelling/ ├── teams/ # Multi-agent collaboration configs └── module.yaml # Module metadata and installation config🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@AGENTS.md` around lines 36 - 47, The workflow directory tree in the README snippet omits src/workflows/brainstorming/, causing docs to be out of sync with src/workflows/README.md; update the diagram block to include the brainstorming folder (e.g., add a line like ├── brainstorming/ under src/workflows/) and ensure the tree matches the actual repository layout referenced by src/workflows/README.md so new contributors see the correct structure.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/workflows/bmad-cis-innovation-strategy/workflow.md`:
- Around line 25-32: The current default_output_file interpolation uses the raw
`date` (full current datetime) which can include ":" and break Windows paths;
update the code that defines `date` (the value used to build
`default_output_file`) to produce a filesystem-safe timestamp (e.g., format as
YYYYMMDD-HHMMSS or replace/strip characters like ":" and spaces) so
`default_output_file = {output_folder}/innovation-strategy-{date}.md` never
contains illegal filename chars; ensure the change is applied where `date` is
computed so all uses of `default_output_file` and any related filename
generation (e.g., in template or save routines) get the sanitized timestamp.
---
Outside diff comments:
In `@AGENTS.md`:
- Around line 36-47: The workflow directory tree in the README snippet omits
src/workflows/brainstorming/, causing docs to be out of sync with
src/workflows/README.md; update the diagram block to include the brainstorming
folder (e.g., add a line like ├── brainstorming/ under src/workflows/) and
ensure the tree matches the actual repository layout referenced by
src/workflows/README.md so new contributors see the correct structure.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ca2c8ee6-3310-4a6b-a608-c4127cf9f0db
⛔ Files ignored due to path filters (2)
src/module-help.csvis excluded by!**/*.csvsrc/workflows/bmad-cis-innovation-strategy/innovation-frameworks.csvis excluded by!**/*.csv
📒 Files selected for processing (9)
AGENTS.mdsrc/agents/innovation-strategist.agent.yamlsrc/workflows/README.mdsrc/workflows/bmad-cis-innovation-strategy/SKILL.mdsrc/workflows/bmad-cis-innovation-strategy/bmad-skill-manifest.yamlsrc/workflows/bmad-cis-innovation-strategy/template.mdsrc/workflows/bmad-cis-innovation-strategy/workflow.mdsrc/workflows/innovation-strategy/README.mdsrc/workflows/innovation-strategy/workflow.yaml
💤 Files with no reviewable changes (2)
- src/workflows/innovation-strategy/README.md
- src/workflows/innovation-strategy/workflow.yaml
Comment on lines
+25
to
+32
| - `date` as the system-generated current datetime | ||
|
|
||
| ### Paths | ||
|
|
||
| - `skill_path` = `{project-root}/_bmad/cis/workflows/bmad-cis-innovation-strategy` | ||
| - `template_file` = `./template.md` | ||
| - `innovation_frameworks_file` = `./innovation-frameworks.csv` | ||
| - `default_output_file` = `{output_folder}/innovation-strategy-{date}.md` |
There was a problem hiding this comment.
Use a filesystem-safe timestamp for default_output_file.
date is defined as the full current datetime and then interpolated directly into the filename. If that value includes : characters, the default save path will be invalid on Windows.
🛠️ Suggested fix
- `date` as the system-generated current datetime
+- `date_slug` as a filesystem-safe timestamp (for example `YYYY-MM-DD` or `YYYYMMDD-HHmmss`)
...
-- `default_output_file` = `{output_folder}/innovation-strategy-{date}.md`
+- `default_output_file` = `{output_folder}/innovation-strategy-{date_slug}.md`📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - `date` as the system-generated current datetime | |
| ### Paths | |
| - `skill_path` = `{project-root}/_bmad/cis/workflows/bmad-cis-innovation-strategy` | |
| - `template_file` = `./template.md` | |
| - `innovation_frameworks_file` = `./innovation-frameworks.csv` | |
| - `default_output_file` = `{output_folder}/innovation-strategy-{date}.md` | |
| - `date_slug` as a filesystem-safe timestamp (for example `YYYY-MM-DD` or `YYYYMMDD-HHmmss`) | |
| ### Paths | |
| - `skill_path` = `{project-root}/_bmad/cis/workflows/bmad-cis-innovation-strategy` | |
| - `template_file` = `./template.md` | |
| - `innovation_frameworks_file` = `./innovation-frameworks.csv` | |
| - `default_output_file` = `{output_folder}/innovation-strategy-{date_slug}.md` |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/workflows/bmad-cis-innovation-strategy/workflow.md` around lines 25 - 32,
The current default_output_file interpolation uses the raw `date` (full current
datetime) which can include ":" and break Windows paths; update the code that
defines `date` (the value used to build `default_output_file`) to produce a
filesystem-safe timestamp (e.g., format as YYYYMMDD-HHMMSS or replace/strip
characters like ":" and spaces) so `default_output_file =
{output_folder}/innovation-strategy-{date}.md` never contains illegal filename
chars; ensure the change is applied where `date` is computed so all uses of
`default_output_file` and any related filename generation (e.g., in template or
save routines) get the sanitized timestamp.
Comment on lines
+40
to
+43
| ### Behavioral Constraints | ||
|
|
||
| - Do not give time estimates. | ||
| - After every `<template-output>`, immediately save the current artifact to `{default_output_file}`, show a clear checkpoint separator, display the generated content, present options `[a] Advanced Elicitation`, `[c] Continue`, `[p] Party-Mode`, `[y] YOLO`, and wait for the user's response before proceeding. |
There was a problem hiding this comment.
Resolve the time-estimate contradiction in the prompt contract.
The global rule says not to give time estimates, but later steps ask for a timeline and a phased execution roadmap. That makes the workflow internally inconsistent, so runs will drift depending on which instruction the model prioritizes.
🧭 Suggested clarification
- - Do not give time estimates.
+ - Do not give calendar dates or duration estimates unless the user explicitly asks.
+ - Sequencing work into relative phases is allowed.
...
- - Expected outcomes and timeline
+ - Expected outcomes and sequencing assumptionsAlso applies to: 212-220, 271-277
bmadcode
approved these changes
Mar 14, 2026
bmadcode
force-pushed
the
feature/native-skills-innovation-strategy-slice
branch
from
507d5aa to
bb75f79
Compare
3 tasks
This was referenced Mar 29, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/workflows/innovation-strategy/to native skill shape atsrc/workflows/bmad-cis-innovation-strategy/Proof
npm testnode test/test-installation-components.jssrc/treeDeferred / Notes
Summary by CodeRabbit
Refactor
Documentation