feat(cis): convert storytelling to a native skill#8
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (9)
WalkthroughThe storytelling workflow directory is migrated from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/workflows/bmad-cis-storytelling/workflow.md`:
- Line 89: The workflow expects CSV columns named story_type, name, description,
key_elements, and best_for but the actual CSV (story-types.csv) uses
key_questions and lacks best_for, causing runtime failures; fix this by either
updating story-types.csv to add the missing key_elements (pipe-separated values)
and best_for columns with appropriate values, or modify the workflow parsing
logic in workflow.md to read key_questions (and map it to the workflow's
key_elements variable or rename uses of key_elements to key_questions) and
handle the absent best_for (e.g., default or optional field), ensuring all
references to story_type, name, description, key_elements/best_for are
consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: dfd07a26-3a28-4a23-ab0d-d452dfb688c3
⛔ Files ignored due to path filters (2)
src/module-help.csvis excluded by!**/*.csvsrc/workflows/bmad-cis-storytelling/story-types.csvis excluded by!**/*.csv
📒 Files selected for processing (10)
AGENTS.mdsrc/agents/storyteller/storyteller.agent.yamlsrc/workflows/README.mdsrc/workflows/bmad-cis-storytelling/SKILL.mdsrc/workflows/bmad-cis-storytelling/bmad-skill-manifest.yamlsrc/workflows/bmad-cis-storytelling/template.mdsrc/workflows/bmad-cis-storytelling/workflow.mdsrc/workflows/storytelling/README.mdsrc/workflows/storytelling/instructions.mdsrc/workflows/storytelling/workflow.yaml
💤 Files with no reviewable changes (3)
- src/workflows/storytelling/workflow.yaml
- src/workflows/storytelling/README.md
- src/workflows/storytelling/instructions.md
| <step n="2" goal="Select story framework"> | ||
| Load story frameworks from `{story_frameworks_file}`. | ||
|
|
||
| Parse the framework data with the same storytelling assumptions used by the legacy workflow, including `story_type`, `name`, `description`, `key_elements`, and `best_for`. |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check the actual column headers in story-types.csv
fd -t f 'story-types.csv' --exec head -1 {}Repository: bmad-code-org/bmad-module-creative-intelligence-suite
Length of output: 147
🏁 Script executed:
cd src/workflows/bmad-cis-storytelling && head -100 workflow.md | tail -20Repository: bmad-code-org/bmad-module-creative-intelligence-suite
Length of output: 1011
🏁 Script executed:
grep -n "key_elements\|best_for\|key_questions" src/workflows/bmad-cis-storytelling/workflow.mdRepository: bmad-code-org/bmad-module-creative-intelligence-suite
Length of output: 426
CSV column mismatch will cause runtime failures.
The workflow references key_elements and best_for columns (lines 89, 139–140), but story-types.csv contains key_questions instead and lacks best_for entirely. The workflow explicitly parses pipe-separated key_elements that don't exist in the data source. Update the CSV to include the required columns or revise the workflow to use the actual key_questions column.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/workflows/bmad-cis-storytelling/workflow.md` at line 89, The workflow
expects CSV columns named story_type, name, description, key_elements, and
best_for but the actual CSV (story-types.csv) uses key_questions and lacks
best_for, causing runtime failures; fix this by either updating story-types.csv
to add the missing key_elements (pipe-separated values) and best_for columns
with appropriate values, or modify the workflow parsing logic in workflow.md to
read key_questions (and map it to the workflow's key_elements variable or rename
uses of key_elements to key_questions) and handle the absent best_for (e.g.,
default or optional field), ensuring all references to story_type, name,
description, key_elements/best_for are consistent.
bmadcode
force-pushed
the
feature/native-skills-storytelling-slice
branch
from
58d75be to
8287d17
Compare
2 participants
Summary
src/workflows/storytelling/to native skill shape atsrc/workflows/bmad-cis-storytelling/Proof
npm testnode test/test-installation-components.jssrc/treeDeferred / Notes
key_elements/best_forwhilestory-types.csvprovideskey_questionsSummary by CodeRabbit
New Features
Documentation
Refactor