fix: address review findings from code review

- Fix merge_menu KeyError crash when menu items missing 'code' key
- Fix _is_menu_array to check ALL elements, not just first
- Remove unused import os from resolve-customization.py
- Remove inject.after from agent activation and customize.toml

Author: bmadcode

src/agents/gds-agent-game-architect/SKILL.md

@@ -24,8 +24,6 @@ Use the JSON output as resolved values.
    incorporate its content as high-priority context.
 3. **Load resources** -- If `additional_resources` is not empty, read
    each listed file and incorporate as reference context.
-4. **Inject after** -- If `inject.after` is not empty, read and
-   incorporate its content as supplementary context.
 
 You must fully embody this persona so the user gets the best experience and help they need. Do not break character until the user dismisses this persona. When the user calls a skill, this persona must carry through and remain active.
 

src/agents/gds-agent-game-architect/customize.toml

@@ -53,4 +53,3 @@ Architecture is about delaying decisions until you have enough data. Build for t
 # ──────────────────────────────────────────────────────────────────
 [inject]
 before = ""
-after = ""

src/agents/gds-agent-game-architect/scripts/resolve-customization.py

@@ -21,7 +21,6 @@
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
-        and "code" in value[0]
+        and all(isinstance(item, dict) and "code" in item for item in value)
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/agents/gds-agent-game-designer/SKILL.md

@@ -24,8 +24,6 @@ Use the JSON output as resolved values.
    incorporate its content as high-priority context.
 3. **Load resources** -- If `additional_resources` is not empty, read
    each listed file and incorporate as reference context.
-4. **Inject after** -- If `inject.after` is not empty, read and
-   incorporate its content as supplementary context.
 
 You must fully embody this persona so the user gets the best experience and help they need. Do not break character until the user dismisses this persona. When the user calls a skill, this persona must carry through and remain active.
 

src/agents/gds-agent-game-designer/customize.toml

@@ -53,4 +53,3 @@ Design what players want to FEEL, not what they say they want. Prototype fast -
 # ──────────────────────────────────────────────────────────────────
 [inject]
 before = ""
-after = ""

src/agents/gds-agent-game-designer/scripts/resolve-customization.py

@@ -21,7 +21,6 @@
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
-        and "code" in value[0]
+        and all(isinstance(item, dict) and "code" in item for item in value)
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/agents/gds-agent-game-dev/SKILL.md

@@ -24,8 +24,6 @@ Use the JSON output as resolved values.
    incorporate its content as high-priority context.
 3. **Load resources** -- If `additional_resources` is not empty, read
    each listed file and incorporate as reference context.
-4. **Inject after** -- If `inject.after` is not empty, read and
-   incorporate its content as supplementary context.
 
 You must fully embody this persona so the user gets the best experience and help they need. Do not break character until the user dismisses this persona. When the user calls a skill, this persona must carry through and remain active.
 

src/agents/gds-agent-game-dev/customize.toml

@@ -53,4 +53,3 @@ principles = """\
 # ──────────────────────────────────────────────────────────────────
 [inject]
 before = ""
-after = ""

src/agents/gds-agent-game-dev/scripts/resolve-customization.py

@@ -21,7 +21,6 @@
 
 import argparse
 import json
-import os
 import sys
 import tomllib
 from pathlib import Path
@@ -57,19 +56,21 @@ def load_toml(path: Path) -> dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 def _is_menu_array(value: Any) -> bool:
-    """True when *value* looks like a ``[[menu]]`` array of tables with ``code`` keys."""
+    """True when *value* is a non-empty list where ALL items are dicts with a ``code`` key."""
     return (
         isinstance(value, list)
         and len(value) > 0
-        and isinstance(value[0], dict)
-        and "code" in value[0]
+        and all(isinstance(item, dict) and "code" in item for item in value)
     )
 
 
 def merge_menu(base: list[dict], override: list[dict]) -> list[dict]:
     """Merge-by-code: matching codes replace; new codes append."""
-    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base}
+    result_by_code: dict[str, dict] = {item["code"]: dict(item) for item in base if "code" in item}
     for item in override:
+        if "code" not in item:
+            print(f"warning: menu item missing 'code' key, skipping: {item}", file=sys.stderr)
+            continue
         result_by_code[item["code"]] = dict(item)
     return list(result_by_code.values())
 

src/agents/gds-agent-game-qa/SKILL.md

@@ -24,8 +24,6 @@ Use the JSON output as resolved values.
    incorporate its content as high-priority context.
 3. **Load resources** -- If `additional_resources` is not empty, read
    each listed file and incorporate as reference context.
-4. **Inject after** -- If `inject.after` is not empty, read and
-   incorporate its content as supplementary context.
 
 You must fully embody this persona so the user gets the best experience and help they need. Do not break character until the user dismisses this persona. When the user calls a skill, this persona must carry through and remain active.