fix: harden resolve script type hint + improve inject prompt wording

- Add type: ignore[arg-type] to merge_menu call (Pylance narrowing limitation)
- Reword inject.before in workflows: "prepend to active instructions and follow it"
- Reword inject.after in workflows: "append to active instructions and follow it"
- Make additional_resources lazy: note list but don't eagerly load

Author: bmadcode

src/agents/gds-agent-game-architect/scripts/resolve-customization.py

@@ -91,7 +91,7 @@ def deep_merge(base: dict[str, Any], override: dict[str, Any]) -> dict[str, Any]
         if isinstance(over_val, dict) and isinstance(base_val, dict):
             merged[key] = deep_merge(base_val, over_val)
         elif _is_menu_array(over_val) and _is_menu_array(base_val):
-            merged[key] = merge_menu(base_val, over_val)
+            merged[key] = merge_menu(base_val, over_val)  # type: ignore[arg-type]
         else:
             merged[key] = over_val
 

src/agents/gds-agent-game-designer/scripts/resolve-customization.py

@@ -91,7 +91,7 @@ def deep_merge(base: dict[str, Any], override: dict[str, Any]) -> dict[str, Any]
         if isinstance(over_val, dict) and isinstance(base_val, dict):
             merged[key] = deep_merge(base_val, over_val)
         elif _is_menu_array(over_val) and _is_menu_array(base_val):
-            merged[key] = merge_menu(base_val, over_val)
+            merged[key] = merge_menu(base_val, over_val)  # type: ignore[arg-type]
         else:
             merged[key] = over_val
 

src/agents/gds-agent-game-dev/scripts/resolve-customization.py

@@ -91,7 +91,7 @@ def deep_merge(base: dict[str, Any], override: dict[str, Any]) -> dict[str, Any]
         if isinstance(over_val, dict) and isinstance(base_val, dict):
             merged[key] = deep_merge(base_val, over_val)
         elif _is_menu_array(over_val) and _is_menu_array(base_val):
-            merged[key] = merge_menu(base_val, over_val)
+            merged[key] = merge_menu(base_val, over_val)  # type: ignore[arg-type]
         else:
             merged[key] = over_val
 

src/agents/gds-agent-game-qa/scripts/resolve-customization.py

@@ -91,7 +91,7 @@ def deep_merge(base: dict[str, Any], override: dict[str, Any]) -> dict[str, Any]
         if isinstance(over_val, dict) and isinstance(base_val, dict):
             merged[key] = deep_merge(base_val, over_val)
         elif _is_menu_array(over_val) and _is_menu_array(base_val):
-            merged[key] = merge_menu(base_val, over_val)
+            merged[key] = merge_menu(base_val, over_val)  # type: ignore[arg-type]
         else:
             merged[key] = over_val
 

src/agents/gds-agent-game-scrum-master/scripts/resolve-customization.py

@@ -91,7 +91,7 @@ def deep_merge(base: dict[str, Any], override: dict[str, Any]) -> dict[str, Any]
         if isinstance(over_val, dict) and isinstance(base_val, dict):
             merged[key] = deep_merge(base_val, over_val)
         elif _is_menu_array(over_val) and _is_menu_array(base_val):
-            merged[key] = merge_menu(base_val, over_val)
+            merged[key] = merge_menu(base_val, over_val)  # type: ignore[arg-type]
         else:
             merged[key] = over_val
 

src/agents/gds-agent-game-solo-dev/scripts/resolve-customization.py

@@ -91,7 +91,7 @@ def deep_merge(base: dict[str, Any], override: dict[str, Any]) -> dict[str, Any]
         if isinstance(over_val, dict) and isinstance(base_val, dict):
             merged[key] = deep_merge(base_val, over_val)
         elif _is_menu_array(over_val) and _is_menu_array(base_val):
-            merged[key] = merge_menu(base_val, over_val)
+            merged[key] = merge_menu(base_val, over_val)  # type: ignore[arg-type]
         else:
             merged[key] = over_val
 

src/agents/gds-agent-tech-writer/scripts/resolve-customization.py

@@ -91,7 +91,7 @@ def deep_merge(base: dict[str, Any], override: dict[str, Any]) -> dict[str, Any]
         if isinstance(over_val, dict) and isinstance(base_val, dict):
             merged[key] = deep_merge(base_val, over_val)
         elif _is_menu_array(over_val) and _is_menu_array(base_val):
-            merged[key] = merge_menu(base_val, over_val)
+            merged[key] = merge_menu(base_val, over_val)  # type: ignore[arg-type]
         else:
             merged[key] = over_val
 

src/workflows/1-preproduction/gds-brainstorm-game/SKILL.md

@@ -13,8 +13,8 @@ Resolve `inject` and `additional_resources` from customization:
 Run: `python3 scripts/resolve-customization.py gds-brainstorm-game --key inject --key additional_resources`
 Use the JSON output as resolved values.
 
-If `inject.before` is not empty, incorporate its content as high-priority context.
-If `additional_resources` is not empty, read each listed file and incorporate as reference context.
+1. **Inject before** -- If `inject.before` resolved to a non-empty value, prepend it to your active instructions and follow it.
+2. **Available resources** -- Note the `additional_resources` list. Do not read these files now; they are available for the injected prompt or workflow steps to reference when needed.
 
 Follow the instructions in ./workflow.md.
 
@@ -23,4 +23,4 @@ Follow the instructions in ./workflow.md.
 After the workflow completes, resolve `inject.after` from customization:
 Run: `python3 scripts/resolve-customization.py gds-brainstorm-game --key inject.after`
 
-If resolved `inject.after` is not empty, incorporate its content as a final checklist or validation gate.
+If resolved `inject.after` is not empty, append it to your active instructions and follow it.

src/workflows/1-preproduction/gds-brainstorm-game/scripts/resolve-customization.py

@@ -91,7 +91,7 @@ def deep_merge(base: dict[str, Any], override: dict[str, Any]) -> dict[str, Any]
         if isinstance(over_val, dict) and isinstance(base_val, dict):
             merged[key] = deep_merge(base_val, over_val)
         elif _is_menu_array(over_val) and _is_menu_array(base_val):
-            merged[key] = merge_menu(base_val, over_val)
+            merged[key] = merge_menu(base_val, over_val)  # type: ignore[arg-type]
         else:
             merged[key] = over_val
 

src/workflows/1-preproduction/gds-create-game-brief/SKILL.md

@@ -13,8 +13,8 @@ Resolve `inject` and `additional_resources` from customization:
 Run: `python3 scripts/resolve-customization.py gds-create-game-brief --key inject --key additional_resources`
 Use the JSON output as resolved values.
 
-If `inject.before` is not empty, incorporate its content as high-priority context.
-If `additional_resources` is not empty, read each listed file and incorporate as reference context.
+1. **Inject before** -- If `inject.before` resolved to a non-empty value, prepend it to your active instructions and follow it.
+2. **Available resources** -- Note the `additional_resources` list. Do not read these files now; they are available for the injected prompt or workflow steps to reference when needed.
 
 Follow the instructions in ./workflow.md.
 
@@ -23,4 +23,4 @@ Follow the instructions in ./workflow.md.
 After the workflow completes, resolve `inject.after` from customization:
 Run: `python3 scripts/resolve-customization.py gds-create-game-brief --key inject.after`
 
-If resolved `inject.after` is not empty, incorporate its content as a final checklist or validation gate.
+If resolved `inject.after` is not empty, append it to your active instructions and follow it.