feat: convert all agents and workflows to native skill format#6
Closed
bmadcode wants to merge 3 commits into
Closed
feat: convert all agents and workflows to native skill format#6bmadcode wants to merge 3 commits into
bmadcode wants to merge 3 commits into
Conversation
Convert 7 agent YAML files to gds-agent-* skill directories. Add SKILL.md passthrough to 27 workflow directories. Rename 22 workflow directories to match gds- prefixed skill names. Update all workflow_path references in 36 step files. Standardize all SKILL.md descriptions. Update module-help.csv to use skill: refs. Remove teams folder. Agents: Samus (Designer), Cloud (Architect), Link (Dev), Indie (Solo Dev), Max (Scrum Master), GLaDOS (QA), Paige (Tech Writer). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Important Review skippedToo many files! This PR contains 293 files, which is 143 over the limit of 150. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (7)
📒 Files selected for processing (293)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Augment PR SummarySummary: This PR migrates the Game Dev Studio module’s agents and workflows from legacy agent/workflow definitions into the native “skill directory” format. Changes:
Technical Notes: This is largely a structural/content refactor; correctness hinges on skill discovery/registration and on all cross-file path references remaining resolvable after renames. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| @@ -1,44 +0,0 @@ | |||
| # Game Architect Agent Definition | |||
There was a problem hiding this comment.
With all *.agent.yaml files removed, test/validate-agent-schema.cjs currently exits with failure when it finds zero agent files (it treats this as a configuration error). If that validator is part of CI, this PR may start failing until the validation approach is updated for the new skill-based agent format.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| # Handoff References | ||
| gameBriefWorkflow: '{project-root}/_bmad/gds/workflows/1-preproduction/game-brief/workflow.yaml' | ||
| gddWorkflow: '{project-root}/_bmad/gds/workflows/2-design/gdd/workflow.yaml' | ||
| gameBriefWorkflow: '{project-root}/_bmad/gds/workflows/1-preproduction/gds-create-game-brief/workflow.yaml' |
There was a problem hiding this comment.
These handoff references point at .../workflow.yaml, but the renamed workflow directories appear to ship only workflow.md (no workflow.yaml), so these handoff links look like they’ll be broken at runtime. Worth confirming what the expected entrypoint filename is for workflow handoffs in the new skill layout.
Severity: medium
Other Locations
src/workflows/1-preproduction/gds-create-game-brief/steps/step-08-complete.md:14src/workflows/2-design/gds-create-gdd/steps/step-14-complete.md:15src/workflows/2-design/gds-create-narrative/steps/step-11-complete.md:14src/workflows/4-production/gds-correct-course/checklist.md:3src/workflows/gds-document-project/instructions.md:4
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| canonicalId: gds-validate-prd | ||
| type: workflow | ||
| description: "Validate a PRD against standards" | ||
| type: skill |
There was a problem hiding this comment.
This directory-level bmad-skill-manifest.yaml now declares type: skill, but the folder has no SKILL.md and appears to be a container for multiple sub-skills (create/edit/validate PRD). If the loader registers every manifest as a skill, this could create an invalid or duplicate skill entry.
Severity: low
Other Locations
src/workflows/1-preproduction/research/bmad-skill-manifest.yaml:1
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Remove package-lock.json from .gitignore and commit lock file. CI workflow uses npm ci which requires a lock file, and actions/setup-node cache: npm requires it for cache keys. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Agent YAML files no longer exist after skill conversion. Remove test/ directory, schema validation scripts, and CI validate job that depended on the old format. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code