apd: fix some module scripts won't add AP_MODULE environment var#1474
Merged
Conversation
AP_MODULE environment var will only pass in exec_script, that's cause only stage-scripts, action.sh and uninstall scripts have this environment var So, it cause customize.sh, and meta*.sh won't have this envionment var And module developers will see them can't use apd module config set command, because apd throw `This command must be run in the context of a module or passed --internal <name>` Taking the magic_mount_rs module as an example: before: ``` APATCH='true' ``` after: ``` APATCH='true' AP_MODULE='magic_mount_rs' ``` Co-authored-by: AlexLiuDev233 <wzylin11@outlook.com>
Prslc
pushed a commit
to Prslc/APatch
that referenced
this pull request
May 24, 2026
…x121#1474) AP_MODULE environment var will only pass in exec_script, that's cause only stage-scripts, action.sh and uninstall scripts have this environment var So, it cause customize.sh, and meta*.sh won't have this envionment var And module developers will see them can't use apd module config set command, because apd throw `This command must be run in the context of a module or passed --internal <name>` Taking the magic_mount_rs module as an example: before: ``` APATCH='true' ``` after: ``` APATCH='true' AP_MODULE='magic_mount_rs' ``` Co-authored-by: AlexLiuDev233 <wzylin11@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AP_MODULE environment var will only pass in exec_script, that's cause only stage-scripts, action.sh and uninstall scripts have this environment var
So, it cause customize.sh, and meta*.sh won't have this envionment var And module developers will see them can't use apd module config set command, because apd throw
This command must be run in the context of a module or passed --internal <name>Taking the magic_mount_rs module as an example:
before:
after: