Skip to content

Commit c806b12

Browse files
committed
Add model capacity of shortcuts.xml & contexMenu.xml for administration
Fix notepad-plus-plus#17872
1 parent 49af4b4 commit c806b12

3 files changed

Lines changed: 45 additions & 8 deletions

File tree

PowerEditor/bin/change.log

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,28 @@
1+
Notepad++ v8.9.3 regression fixes, bug-fixes & new improvements:
2+
3+
1. Regression fix: a crash in User Defined Language.
4+
2. Regression fix: installing (or removing) plugin re-opens Notepad++ with permanent admin privilege.
5+
3. Regression-fix: wrongly added parenthesis for some multi-bytes characters.
6+
4. Regression-fix: incorrect function list text display for non-UTF8 documents.
7+
5. Regression-fix: ProjectPanel Workspace text localization issue.
8+
6. Regression-fix: Change History margin not enabled by default.
9+
7. Regression-fix: Notepad++ update & plugin download fail behind corporate MITM proxies.
10+
8. Security enhancement: Update cURL to v8.19.0 in auto-updater (WinGUp) to fix cURL security issue (CVE-2025-14819).
11+
9. Improve performance by migrating the XML parser from TinyXML to pugixml.
12+
10. Update Scintilla to 5.6.0 & Lexilla to 5.4.7.
13+
11. Fix the issue where printing caused Notepad++ to crash.
14+
12. Fix Find in Files failing to search file content on disk.
15+
13. Add disableNppAutoUpdate.xml to disable auto-update when WinGUp (GUP.exe) is present.
16+
14. Fix a memory leak on exit.
17+
15. Fix installed auto-completion files not overwritten after update.
18+
16. Add an option to disable selected text drag-and-drop.
19+
17. Fix wrong theme-writing path for non-ProgramFiles installations.
20+
18. Enhancement: prevent XML config files from being overwritten when updating portable package (copy/paste).
21+
19. Fix incomplete Find dialg tab translation when 1st opêned from Project Panels.
22+
20. Fix Notepad++ spawning a new Windows Explorer process in Task Manager.
23+
21. Add Function List & Autocompletion for D language.
24+
25+
126
Notepad++ v8.9.2 regression fixes, bug-fixes & new improvements:
227

328
1. Security enhancement: Make updater check interity & authenticity of server-returned XML (XMLDsig).
@@ -28,7 +53,7 @@ Notepad++ v8.9.1 regression fixes, bug-fixes & new improvements:
2853

2954

3055
Get more info on
31-
https://notepad-plus-plus.org/downloads/v8.9.2/
56+
https://notepad-plus-plus.org/downloads/v8.9.3/
3257

3358

3459
Included plugins:
@@ -40,4 +65,4 @@ Included plugins:
4065

4166
Updater (Installer only):
4267

43-
* WinGUp (for Notepad++) v5.4
68+
* WinGUp (for Notepad++) v5.4.1

PowerEditor/src/Parameters.cpp

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -637,6 +637,7 @@ static constexpr ScintillaKeyDefinition scintKeyDefs[]
637637
};
638638

639639
#define SHORTCUTSXML_FILENAME L"shortcuts.xml"
640+
#define SHORTCUTSXML_MODEL_FILENAME L"shortcuts.model.xml"
640641

641642
#define SESSION_BACKUP_EXT L".inCaseOfCorruption.bak"
642643

@@ -1660,7 +1661,12 @@ bool NppParameters::load()
16601661

16611662
if (!doesFileExist(_shortcutsPath.c_str()))
16621663
{
1663-
generateXmlFromScratch(_shortcutsPath.c_str(), SHORTCUT_XML_CONTENT);
1664+
std::wstring srcShortcutsPath(_nppPath);
1665+
pathAppend(srcShortcutsPath, SHORTCUTSXML_MODEL_FILENAME);
1666+
if (doesFileExist(srcShortcutsPath.c_str()))
1667+
::CopyFile(srcShortcutsPath.c_str(), _shortcutsPath.c_str(), TRUE);
1668+
else
1669+
generateXmlFromScratch(_shortcutsPath.c_str(), SHORTCUT_XML_CONTENT);
16641670
}
16651671

16661672
_pXmlShortcutDoc = new NppXml::NewDocument();
@@ -1690,7 +1696,13 @@ bool NppParameters::load()
16901696

16911697
if (!doesFileExist(_contextMenuPath.c_str()))
16921698
{
1693-
generateXmlFromScratch(_contextMenuPath.c_str(), CONTEXTMENU_XML_CONTENT);
1699+
std::wstring srcContextMenuPath(_nppPath);
1700+
pathAppend(srcContextMenuPath, L"contextMenu.xml");
1701+
1702+
if (doesFileExist(srcContextMenuPath.c_str()))
1703+
::CopyFile(srcContextMenuPath.c_str(), _contextMenuPath.c_str(), TRUE);
1704+
else
1705+
generateXmlFromScratch(_contextMenuPath.c_str(), CONTEXTMENU_XML_CONTENT);
16941706
}
16951707

16961708
_pXmlContextMenuDoc = new NppXml::NewDocument();

PowerEditor/src/resource.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,14 @@
1919

2020
//************ Notepad++ version **************************
2121

22-
#define NOTEPAD_PLUS_VERSION L"Notepad++ v8.9.2"
22+
#define NOTEPAD_PLUS_VERSION L"Notepad++ v8.9.3"
2323

2424
// should be X.Y : ie. if VERSION_DIGITALVALUE == 4, 7, 1, 0 , then X = 4, Y = 71
2525
// ex : #define VERSION_VALUE L"5.63\0"
26-
#define VERSION_INTERNAL_VALUE L"8.92\0"
26+
#define VERSION_INTERNAL_VALUE L"8.93\0"
2727

28-
#define VERSION_PRODUCT_VALUE L"8.9.2\0"
29-
#define VERSION_DIGITALVALUE 8, 9, 2, 0
28+
#define VERSION_PRODUCT_VALUE L"8.9.3\0"
29+
#define VERSION_DIGITALVALUE 8, 9, 3, 0
3030

3131
//**********************************************************
3232

0 commit comments

Comments
 (0)