Skip to content

fix: forward kwargs to aioredis in Redis backends #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dimitryLMEX wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: forward kwargs to aioredis in Redis backends #1107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cryptofeed/backends/redis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ def __init__(self, host='127.0.0.1', port=6379, socket=None, key=None, none_to='
self.numeric_type = numeric_type
self.none_to = none_to
self.running = True
self.conn_kwargs = kwargs


class RedisZSetCallback(RedisCallback):
Expand All @@ -43,7 +44,7 @@ def __init__(self, host='127.0.0.1', port=6379, socket=None, key=None, numeric_t
super().__init__(host=host, port=port, socket=socket, key=key, numeric_type=numeric_type, **kwargs)

async def writer(self):
conn = aioredis.from_url(self.redis)
conn = aioredis.from_url(self.redis, **self.conn_kwargs)

while self.running:
async with self.read_queue() as updates:
Expand All @@ -58,7 +59,7 @@ async def writer(self):

class RedisStreamCallback(RedisCallback):
async def writer(self):
conn = aioredis.from_url(self.redis)
conn = aioredis.from_url(self.redis, **self.conn_kwargs)

while self.running:
async with self.read_queue() as updates:
Expand All @@ -81,7 +82,7 @@ async def writer(self):
class RedisKeyCallback(RedisCallback):

async def writer(self):
conn = aioredis.from_url(self.redis)
conn = aioredis.from_url(self.redis, **self.conn_kwargs)

while self.running:
async with self.read_queue() as updates:
Expand Down