fix: Change default assignment mode to append (KelvinTegelaar#2137)

Update the default assignment mode to 'append' for a less destructive
default.

Frontend PR: KelvinTegelaar/CIPP#6342

Author: KelvinTegelaar

Modules/CIPPCore/Public/Set-CIPPAssignedApplication.ps1

@@ -10,7 +10,7 @@ function Set-CIPPAssignedApplication {
         $ApplicationId,
         $TenantFilter,
         $GroupIds,
-        $AssignmentMode = 'replace',
+        $AssignmentMode = 'append',
         $AssignmentDirection,
         $APIName = 'Assign Application',
         $Headers,

Modules/CIPPCore/Public/Set-CIPPAssignedPolicy.ps1

@@ -15,7 +15,7 @@ function Set-CIPPAssignedPolicy {
         $AssignmentFilterType = 'include',
         $GroupIds,
         $GroupNames,
-        $AssignmentMode = 'replace',
+        $AssignmentMode = 'append',
         $AssignmentDirection
     )
 

Modules/CIPPHTTP/Public/Entrypoints/HTTP Functions/Endpoint/Applications/Invoke-ExecAssignApp.ps1

@@ -31,7 +31,7 @@ function Invoke-ExecAssignApp {
     $Intent = if ([string]::IsNullOrWhiteSpace($Intent)) { 'Required' } else { $Intent }
 
     if ([string]::IsNullOrWhiteSpace($AssignmentMode)) {
-        $AssignmentMode = 'replace'
+        $AssignmentMode = 'append'
     } else {
         $AssignmentMode = $AssignmentMode.ToLower()
         if ($AssignmentMode -notin @('replace', 'append')) {

Modules/CIPPHTTP/Public/Entrypoints/HTTP Functions/Endpoint/MEM/Invoke-ExecAssignPolicy.ps1

@@ -49,7 +49,7 @@ function Invoke-ExecAssignPolicy {
 
     # Validate and default AssignmentMode
     if ([string]::IsNullOrWhiteSpace($AssignmentMode)) {
-        $AssignmentMode = 'replace'
+        $AssignmentMode = 'append'
     }
 
     $AssignTo = if ($AssignTo -ne 'on') { $AssignTo }

Tests/Endpoint/Invoke-ExecAssignApp.Tests.ps1

@@ -0,0 +1,66 @@
+# Pester tests for Invoke-ExecAssignApp assignment mode defaults.
+
+BeforeAll {
+    $RepoRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSCommandPath))
+    $FunctionPath = Get-ChildItem -Path (Join-Path $RepoRoot 'Modules') -Recurse -Filter 'Invoke-ExecAssignApp.ps1' -File |
+        Select-Object -First 1 -ExpandProperty FullName
+
+    ([PSObject].Assembly.GetType('System.Management.Automation.TypeAccelerators')).GetMethod('Add').Invoke(
+        $null, @('HttpStatusCode', [System.Net.HttpStatusCode]))
+
+    class HttpResponseContext {
+        [int]$StatusCode
+        [object]$Body
+    }
+
+    function Set-CIPPAssignedApplication { param($ApplicationId, $TenantFilter, $Intent, $APIName, $Headers, $GroupName, $AssignmentMode) }
+
+    . $FunctionPath
+}
+
+Describe 'Invoke-ExecAssignApp assignment mode' {
+    BeforeEach {
+        $script:assignmentMode = $null
+        Mock -CommandName Set-CIPPAssignedApplication -MockWith {
+            $script:assignmentMode = $AssignmentMode
+        }
+    }
+
+    It 'defaults omitted assignment mode to append' {
+        $request = [pscustomobject]@{
+            Params  = @{ CIPPEndpoint = 'ExecAssignApp' }
+            Headers = @{}
+            Query   = [pscustomobject]@{}
+            Body    = [pscustomobject]@{
+                tenantFilter = 'contoso.onmicrosoft.com'
+                ID           = 'app-1'
+                AppType      = 'Win32Lob'
+                AssignTo     = 'AllDevices'
+            }
+        }
+
+        $response = Invoke-ExecAssignApp -Request $request -TriggerMetadata $null
+
+        $response.StatusCode | Should -Be ([System.Net.HttpStatusCode]::OK)
+        $script:assignmentMode | Should -Be 'append'
+    }
+
+    It 'preserves explicit replace mode' {
+        $request = [pscustomobject]@{
+            Params  = @{ CIPPEndpoint = 'ExecAssignApp' }
+            Headers = @{}
+            Query   = [pscustomobject]@{}
+            Body    = [pscustomobject]@{
+                tenantFilter   = 'contoso.onmicrosoft.com'
+                ID             = 'app-1'
+                AppType        = 'Win32Lob'
+                AssignTo       = 'AllDevices'
+                assignmentMode = 'replace'
+            }
+        }
+
+        $null = Invoke-ExecAssignApp -Request $request -TriggerMetadata $null
+
+        $script:assignmentMode | Should -Be 'replace'
+    }
+}

Tests/Endpoint/Invoke-ExecAssignPolicy.Tests.ps1

@@ -0,0 +1,64 @@
+# Pester tests for Invoke-ExecAssignPolicy assignment mode defaults.
+
+BeforeAll {
+    $RepoRoot = Split-Path -Parent (Split-Path -Parent (Split-Path -Parent $PSCommandPath))
+    $FunctionPath = Get-ChildItem -Path (Join-Path $RepoRoot 'Modules') -Recurse -Filter 'Invoke-ExecAssignPolicy.ps1' -File |
+        Select-Object -First 1 -ExpandProperty FullName
+
+    ([PSObject].Assembly.GetType('System.Management.Automation.TypeAccelerators')).GetMethod('Add').Invoke(
+        $null, @('HttpStatusCode', [System.Net.HttpStatusCode]))
+
+    class HttpResponseContext {
+        [int]$StatusCode
+        [object]$Body
+    }
+
+    function Set-CIPPAssignedPolicy { param($PolicyId, $TenantFilter, $GroupName, $Type, $Headers, $AssignmentMode) }
+
+    . $FunctionPath
+}
+
+Describe 'Invoke-ExecAssignPolicy assignment mode' {
+    BeforeEach {
+        $script:assignmentMode = $null
+        Mock -CommandName Set-CIPPAssignedPolicy -MockWith {
+            $script:assignmentMode = $AssignmentMode
+        }
+    }
+
+    It 'defaults omitted assignment mode to append' {
+        $request = [pscustomobject]@{
+            Params  = @{ CIPPEndpoint = 'ExecAssignPolicy' }
+            Headers = @{}
+            Body    = [pscustomobject]@{
+                tenantFilter = 'contoso.onmicrosoft.com'
+                ID           = 'policy-1'
+                Type         = 'configurationPolicies'
+                AssignTo     = 'AllDevices'
+            }
+        }
+
+        $response = Invoke-ExecAssignPolicy -Request $request -TriggerMetadata $null
+
+        $response.StatusCode | Should -Be ([System.Net.HttpStatusCode]::OK)
+        $script:assignmentMode | Should -Be 'append'
+    }
+
+    It 'preserves explicit replace mode' {
+        $request = [pscustomobject]@{
+            Params  = @{ CIPPEndpoint = 'ExecAssignPolicy' }
+            Headers = @{}
+            Body    = [pscustomobject]@{
+                tenantFilter  = 'contoso.onmicrosoft.com'
+                ID            = 'policy-1'
+                Type          = 'configurationPolicies'
+                AssignTo      = 'AllDevices'
+                assignmentMode = 'replace'
+            }
+        }
+
+        $null = Invoke-ExecAssignPolicy -Request $request -TriggerMetadata $null
+
+        $script:assignmentMode | Should -Be 'replace'
+    }
+}