Skip to content

fix: restore symlinks at container delete time #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnusunny merged 1 commit into from
Feb 14, 2026
Merged

fix: restore symlinks at container delete time #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions samcli/local/docker/container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,11 @@ def delete(self):
shutil.rmtree(self._host_tmp_dir)
LOG.debug("Successfully removed temporary directory %s on the host.", self._host_tmp_dir)

# Restore any symlinks that were temporarily replaced with directories
# during container creation for mount compatibility (Finch/containerd).
# Done at delete time so the bind mounts remain valid for the container's lifetime.
self._restore_mapped_symlinks()

self.id = None

def start(self, input_data=None):
Expand Down Expand Up @@ -486,11 +491,6 @@ def start(self, input_data=None):
if "Ports are not available" in str(ex):
raise PortAlreadyInUse(ex.explanation.decode()) from ex
raise ex
finally:
# Restore any symlinks that were temporarily replaced with directories
# during container creation for mount compatibility (Finch/containerd).
# Must happen after start() since containerd resolves mounts at start time.
self._restore_mapped_symlinks()

def _initialize_concurrency_control(self):
"""
Expand Down