Merge branch 'main' into feat/temporal-instant-tolocalestring

Author: JkrishnaD

.github/workflows/codeql.yml

@@ -30,12 +30,12 @@ jobs:
         persist-credentials: false
 
     - name: Initialize CodeQL
-      uses: github/codeql-action/init@38697555549f1db7851b81482ff19f1fa5c4fedc # v4.34.1
+      uses: github/codeql-action/init@c10b8064de6f491fea524254123dbe5e09572f13 # v4.35.1
       with:
         languages: ${{ matrix.language }}
         build-mode: none
 
     - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@38697555549f1db7851b81482ff19f1fa5c4fedc # v4.34.1
+      uses: github/codeql-action/analyze@c10b8064de6f491fea524254123dbe5e09572f13 # v4.35.1
       with:
         category: "/language:${{matrix.language}}"

.github/workflows/rust.yml

@@ -192,7 +192,7 @@ jobs:
         run: cargo tarpaulin --workspace --features annex-b,intl_bundled,experimental --ignore-tests --engine llvm --out xml
 
       - name: Upload to codecov.io
-        uses: codecov/codecov-action@1af58845a975a7985b0beb0cbe6fbbb71a41dbad # v5
+        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v5
 
   tests:
     name: Test

Cargo.lock

@@ -95,15 +95,15 @@ simple_logger = "5.1.0"
 cargo_metadata = "0.23.1"
 trybuild = "1.0.116"
 rayon = "1.10.0"
-toml = "1.0.7"
+toml = "1.1.0"
 color-eyre = "0.6.3"
 comfy-table = "7.2.2"
 serde_repr = "0.1.20"
 bus = "2.4.1"
 wasm-bindgen = { version = "0.2.97", default-features = false }
 getrandom = { version = "0.4.2", default-features = false }
 console_error_panic_hook = "0.1.7"
-wasm-bindgen-test = "0.3.64"
+wasm-bindgen-test = "0.3.65"
 smol = "2.0.2"
 rustyline = { version = "17.0.2", default-features = false }
 dhat = "0.3.3"

Cargo.toml

@@ -693,14 +693,14 @@ impl Instant {
             // Converting epoch milliseconds
             let epoch_ms = instant.inner.epoch_milliseconds() as f64;
 
-            return format_date_time_locale(
+            format_date_time_locale(
                 locales,
                 options,
                 FormatType::Any,
                 FormatDefaults::All,
                 epoch_ms,
                 context,
-            );
+            )
         }
 
         #[cfg(not(feature = "intl"))]

core/engine/src/builtins/temporal/instant/mod.rs

@@ -4,7 +4,7 @@ use std::sync::atomic::Ordering;
 
 use crate::{
     Context, JsExpect, JsNativeError, JsResult, JsString, JsValue,
-    builtins::array_buffer::BufferObject,
+    builtins::array_buffer::{BufferObject, BufferRef},
     object::{
         JsData, JsObject,
         internal_methods::{
@@ -279,6 +279,26 @@ impl TypedArray {
         // 4. Return true.
         Some(index)
     }
+
+    /// Abstract operation `IsTypedArrayFixedLength ( O )`.
+    ///
+    /// More information:
+    ///  - [ECMAScript reference][spec]
+    ///
+    /// [spec]: https://tc39.es/ecma262/#sec-istypedarrayfixedlength
+    fn is_fixed_length(&self) -> bool {
+        // 1. If O.[[ArrayLength]] is auto, return false.
+        if self.is_auto_length() {
+            return false;
+        }
+
+        // 2. Let buffer be O.[[ViewedArrayBuffer]].
+        match self.viewed_array_buffer().as_buffer() {
+            // 3. If IsFixedLengthArrayBuffer(buffer) is false and IsSharedArrayBuffer(buffer) is false, return false.
+            BufferRef::Buffer(buf) => buf.is_fixed_len(),
+            BufferRef::SharedBuffer(_) => true,
+        }
+    }
 }
 
 // Integer-Indexed Exotic Objects [[PreventExtensions]] ( O )
@@ -295,8 +315,9 @@ pub(crate) fn typed_array_exotic_prevent_extensions(
             .downcast_ref::<TypedArray>()
             .js_expect("must be a TypedArray")?;
 
-        ta.viewed_array_buffer().as_buffer().is_fixed_len()
-    };
+        ta.is_fixed_length()
+    }; // Note: this block ensures that the borrow of obj is dropped
+    // so it may be re-borrowed in step 3
 
     // 1. If IsTypedArrayFixedLength(O) is false, return false.
     if !is_fixed_length {

core/engine/src/builtins/typed_array/object.rs

@@ -161,3 +161,24 @@ fn typedarray_conversion_mismatch_throws() {
         ),
     ]);
 }
+
+#[test]
+fn typedarray_exotic_prevent_extensions() {
+    // ref: https://github.com/tc39/test262/blob/main/test/staging/built-ins/Object/preventExtensions/preventExtensions-variable-length-typed-arrays.js
+    run_test_actions([
+        TestAction::run("const gsab = new SharedArrayBuffer(4, { maxByteLength: 8 });"),
+        TestAction::run("const fixedLength = new Uint8Array(gsab, 0, 4);"),
+        TestAction::run("const fixedLengthWithOffset = new Uint8Array(gsab, 2, 2);"),
+        TestAction::run("Object.preventExtensions(fixedLength);"),
+        TestAction::run("Object.preventExtensions(fixedLengthWithOffset);"),
+        TestAction::assert("!Object.isExtensible(fixedLength)"),
+        TestAction::assert("!Object.isExtensible(fixedLengthWithOffset)"),
+        TestAction::run("const rab = new ArrayBuffer(4);"),
+        TestAction::run("const fixedLength1 = new Uint8Array(rab, 0, 4);"),
+        TestAction::run("const fixedLengthWithOffset1 = new Uint8Array(rab, 2, 2);"),
+        TestAction::run("Object.preventExtensions(fixedLength1);"),
+        TestAction::run("Object.preventExtensions(fixedLengthWithOffset1);"),
+        TestAction::assert("!Object.isExtensible(fixedLength1)"),
+        TestAction::assert("!Object.isExtensible(fixedLengthWithOffset1)"),
+    ]);
+}

core/engine/src/builtins/typed_array/tests.rs

@@ -8,4 +8,4 @@ edition.workspace = true
 boa_engine = { workspace = true }
 
 [dev-dependencies]
-insta = { version = "1.46.3", features = ["filters", "glob"] }
+insta = { version = "1.47.0", features = ["filters", "glob"] }