feat: setup initial oscars integration#5426
Open
shruti2522 wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
Waiting On Review
jedel1043
reviewed
Jul 10, 2026
|
|
||
| [patch."https://github.com/boa-dev/oscars.git"] | ||
| oscars = { path = "../oscars/oscars" } | ||
| oscars_derive = { path = "../oscars/oscars_derive" } |
Member
There was a problem hiding this comment.
Might want to remove this for the upstream code, since it would make it a bit hard to test things using the CI (if we need to)
I think you can still configure this using the $HOME/.cargo/config.toml file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is an early draft with the initial setup to integrate oscars in boa. We are currently using
null_collector_brandedas the baseline for integrationIt changes the following:
boa/core/gc/src/lib.rsby moving the oldlogic intoboa_allocator.rsoscars_backendfeature flag to toggle between the current GC and the new oscars gc(Note: building with the
oscars_backendfeature will currently fail since the engine still needs the new'gclifetimes to be threaded. I will be adding those updates in the next few commits)