Update Duration's inner representation from floating point to integers.#268
Merged
Conversation
nekevss
commented
Apr 29, 2025
Member
Author
|
I'm not going to merge this for now. I was doing some testing locally with Boa, and there's a couple more edge cases that I need to look into. |
nekevss
force-pushed
the
update-duration-repr
branch
from
63aa66e to
6f2e729
Compare
nekevss
added a commit
that referenced
this pull request
May 10, 2025
…s. (#268) This begins to address #189 and closes #250. This completely updates the inner representation for `Duration`, migrating from `FiniteF64`s to `i64`. Due to the change there were also some fairly robust changes across the internals for `Duration`. There were also some related updates made to some parts of rounding to bring it more in line with the specification and also calculate values without needing fractional values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This begins to address #189 and closes #250.
This completely updates the inner representation for
Duration, migrating fromFiniteF64s toi64. Due to the change there were also some fairly robust changes across the internals forDuration.There were also some related updates made to some parts of rounding to bring it more in line with the specification and also calculate values without needing fractional values.