Skip to content

Commit 2fbe03e

Browse files
Ma77Ballchenlicaaglinxinyuan
authored andcommitted
fix: only run workflow build and deploy image action if scheduled or auto run if on… (apache#4214)
<!-- Thanks for sending a pull request (PR)! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: [Contributing to Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) 2. Ensure you have added or run the appropriate tests for your PR 3. If the PR is work in progress, mark it a draft on GitHub. 4. Please write your PR title to summarize what this PR proposes, we are following Conventional Commits style for PR titles as well. 5. Be sure to keep the PR description updated to reflect all changes. --> ### What changes were proposed in this PR? <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes. Here are some tips for you: 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. 3. If it is a refactoring, clarify what has been changed. 3. It would be helpful to include a before-and-after comparison using screenshots or GIFs. 4. Please consider writing useful notes for better and faster reviews. --> This PR fixes the CI workflow so the “build and push images” job does not run on every contributor’s branch. The job is now gated with a job-level condition: if: github.event_name != 'schedule' || github.repository == 'apache/texera' This ensures the job runs for normal (non-scheduled) events, and for scheduled runs only when the workflow is running in the upstream apache/texera repository. ### Any related issues, documentation, discussions? <!-- Please use this section to link other resources if not mentioned already. 1. If this PR fixes an issue, please include `Fixes apache#1234`, `Resolves apache#1234` or `Closes apache#1234`. If it is only related, simply mention the issue number. 2. If there is design documentation, please add the link. 3. If there is a discussion in the mailing list, please add the link. --> N/A ### How was this PR tested? <!-- If tests were added, say they were added here. Or simply mention that if the PR is tested with existing test cases. Make sure to include/update test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> CI workflow change only. Verified the condition restricts scheduled runs to apache/texera while allowing non-scheduled events to proceed as before. ### Was this PR authored or co-authored using generative AI tooling? <!-- If generative AI tooling has been used in the process of authoring this PR, please include the phrase: 'Generated-by: ' followed by the name of the tool and its version. If no, write 'No'. Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details. --> No Co-authored-by: Chen Li <chenli@gmail.com> Co-authored-by: Xinyuan Lin <xinyual3@uci.edu>
1 parent 9c91ae6 commit 2fbe03e

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

.github/workflows/build-and-push-images.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ jobs:
6565
# Step 0: Set runtime parameters (handles both manual and scheduled runs)
6666
set-parameters:
6767
runs-on: ubuntu-latest
68+
if: github.event_name != 'schedule' || github.repository == 'apache/texera'
6869
outputs:
6970
branch: ${{ steps.set-params.outputs.branch }}
7071
image_tag: ${{ steps.set-params.outputs.image_tag }}

0 commit comments

Comments
 (0)