Skip to content

pkgconf install#306

Merged
bobluppes merged 2 commits into
bobluppes:mainfrom
mccakit:pr2
Mar 27, 2026
Merged

pkgconf install#306
bobluppes merged 2 commits into
bobluppes:mainfrom
mccakit:pr2

Conversation

@mccakit
Copy link
Copy Markdown
Contributor

@mccakit mccakit commented Mar 9, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.58%. Comparing base (dcea902) to head (24ded90).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files          59       59           
  Lines        2621     2621           
  Branches      136      136           
=======================================
  Hits         2610     2610           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Owner

@bobluppes bobluppes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, LGTM

@bobluppes bobluppes merged commit 2a4715f into bobluppes:main Mar 27, 2026
8 checks passed
@FredericSabot
Copy link
Copy Markdown

Hello,

This PR causes issues when getting the lib through FetchContent

FetchContent_Declare(
        graaflib
        GIT_REPOSITORY https://github.com/bobluppes/graaf.git
        GIT_TAG main
)

CMake Error: File /Users/fsabot/Desktop/Project/packaging/graaf.pc.in does not exist.
CMake Error at build/_deps/graaflib-src/CMakeLists.txt:46 (configure_file):
configure_file Problem configuring file

@FredericSabot
Copy link
Copy Markdown

Our current workaround is to manually copy the packaging dir from graaf to our project, but this is slightly inconvenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants