Fixing issues where serialport library is installed incorrectly#1
Open
thedamian wants to merge 1 commit into
Open
Fixing issues where serialport library is installed incorrectly#1thedamian wants to merge 1 commit into
thedamian wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At least in Linux (And I think windows and Mac too) the serial port library needs to be installed FIRST.
I've also updated the reference to the latest johnny-five library.
To re-create the problem i'm fixing. clone this and just npm i it should install but then running the:
node motor-sumo.jscommand will complain about serialport missing.
I'm on the latest Node 12.7
If anyone can confirm that on Mac or Windows this works just fine. then I suggest merging this as it'll help all the linux folks out there at the very least (if not fix future Mac or Windows issues)